From owner-svn-src-all@FreeBSD.ORG Mon Oct 26 16:33:05 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6F319106568B; Mon, 26 Oct 2009 16:33:05 +0000 (UTC) (envelope-from xcllnt@mac.com) Received: from asmtpout029.mac.com (asmtpout029.mac.com [17.148.16.104]) by mx1.freebsd.org (Postfix) with ESMTP id 55DEC8FC17; Mon, 26 Oct 2009 16:33:04 +0000 (UTC) MIME-version: 1.0 Content-transfer-encoding: 7BIT Content-type: text/plain; charset=us-ascii; format=flowed; delsp=yes Received: from macbook-pro.jnpr.net (natint3.juniper.net [66.129.224.36]) by asmtp029.mac.com (Sun Java(tm) System Messaging Server 6.3-8.01 (built Dec 16 2008; 32bit)) with ESMTPSA id <0KS4006WARAONC40@asmtp029.mac.com>; Mon, 26 Oct 2009 09:33:04 -0700 (PDT) From: Marcel Moolenaar In-reply-to: <200910260837.23479.jhb@freebsd.org> Date: Mon, 26 Oct 2009 09:32:48 -0700 Message-id: <8082A638-C5BA-42F9-8C2E-DA31EF084840@mac.com> References: <200910232253.n9NMr10R074584@svn.freebsd.org> <200910260837.23479.jhb@freebsd.org> To: John Baldwin X-Mailer: Apple Mail (2.1076) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r198431 - head/sys/dev/pci X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Oct 2009 16:33:05 -0000 On Oct 26, 2009, at 5:37 AM, John Baldwin wrote: >> Log: >> BIOSes, buggy or otherwise, are i386 or amd64 specific. >> Have the early USB takeover enabled for i386 and amd64 >> by default. >> This also avoids a panic on PowerPC where the resource >> isn't released properly and we find a busy resource >> when the USB host controller wants to allocate it... > > Presumably such systems won't set the 'BIOS owned' bit in the their > legacy > support registers in which case these routines are NOPs (they just > read the > register, see the bit is clear, and exit). The resource bug sounds > like a > real one that should be fixed and would probably affect any x86 > systems who > have USB disabled in the BIOS, so that should be fixed rather than > papered > over. Please revert. *sigh* The change was made because 1) doing this as part of the PCI code is unnecessary for non-PC HW, and 2) it's entirely untested on non-PC HW and the gratuitous change can therefore only do harm -- he, guess what, it did do harm. Unless people fix the resource stuff this change cannot be reverted. After the resource fix has gone in, I still object to this being reverted on grounds of gratuitous code bloat. I say this with ARM, MIPS and PowerPC/Book-E in mind. > Note that the legacy support register stuff is part of the uhci/ohci/ > ehci > specifications, and that the code to frob it has been part of the same > drivers since their inception. If it had been an actual problem > then it > would have been disabled back when USB was enabled for other > architectures. This is entirely besides the point... -- Marcel Moolenaar xcllnt@mac.com