From owner-freebsd-ports  Sat Jun  9 14:42:45 2001
Delivered-To: freebsd-ports@freebsd.org
Received: from wall.polstra.com (rtrwan160.accessone.com [206.213.115.74])
	by hub.freebsd.org (Postfix) with ESMTP id 93C6A37B401
	for <ports@freebsd.org>; Sat,  9 Jun 2001 14:42:41 -0700 (PDT)
	(envelope-from jdp@wall.polstra.com)
Received: from vashon.polstra.com (vashon.polstra.com [206.213.73.13])
	by wall.polstra.com (8.11.3/8.11.1) with ESMTP id f59Lgd223398;
	Sat, 9 Jun 2001 14:42:39 -0700 (PDT)
	(envelope-from jdp@wall.polstra.com)
Received: (from jdp@localhost)
	by vashon.polstra.com (8.11.3/8.11.0) id f59LgcL55293;
	Sat, 9 Jun 2001 14:42:38 -0700 (PDT)
	(envelope-from jdp)
Date: Sat, 9 Jun 2001 14:42:38 -0700 (PDT)
Message-Id: <200106092142.f59LgcL55293@vashon.polstra.com>
To: ports@freebsd.org
From: John Polstra <jdp@polstra.com>
Cc: mjacob@feral.com
Subject: Re: not sure if this is a good patch or not... (fwd)
In-Reply-To: <20010609132536.R4572-100000@wonky.feral.com>
References: <20010609132536.R4572-100000@wonky.feral.com>
Organization: Polstra & Co., Seattle, WA
Sender: owner-freebsd-ports@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-ports.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo?subject=subscribe%20freebsd-ports>
List-Unsubscribe: <mailto:majordomo?subject=unsubscribe%20freebsd-ports>
X-Loop: FreeBSD.org

In article <20010609132536.R4572-100000@wonky.feral.com>,
Matthew Jacob  <mjacob@feral.com> wrote:

> Needed to compile under 4.3:
> 
> Index: files/patch-Makefile.Linux.Mesa
> ===================================================================
> RCS file: /home/ncvs/ports/games/tank/files/patch-Makefile.Linux.Mesa,v
> retrieving revision 1.1
> diff -u -r1.1 patch-Makefile.Linux.Mesa
> --- files/patch-Makefile.Linux.Mesa	2001/03/14 12:20:49	1.1
> +++ files/patch-Makefile.Linux.Mesa	2001/06/09 20:16:59
> @@ -38,7 +38,7 @@
>   	$(CC) -o $(EXECNAME) $(Obj) $(LDFLAGS) \
>  -	-lMesaaux -lMesatk -lMesaGLU -lMesaGL \
>  -	-lXext -lX11 -lm
> -+	-laux -lGLU -lGL -lXext -lX11 -lm
> ++	-laux -lGLU -lGL -lXext -lX11 -lm -lc_r
>   	@echo "****** Done ******"
> 
>   linux: $(Obj)
> 

Not a good patch.  Add "-pthread" to LDFLAGS instead.  The patch as
it stands will link in both -lc_r and -lc, but the two cannot coexist
safely.

John
-- 
  John Polstra                                               jdp@polstra.com
  John D. Polstra & Co., Inc.                        Seattle, Washington USA
  "Disappointment is a good sign of basic intelligence."  -- Chögyam Trungpa


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message