From owner-freebsd-net@freebsd.org  Wed May 18 01:15:07 2016
Return-Path: <owner-freebsd-net@freebsd.org>
Delivered-To: freebsd-net@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id A870BB401D7
 for <freebsd-net@mailman.ysv.freebsd.org>;
 Wed, 18 May 2016 01:15:07 +0000 (UTC)
 (envelope-from daemon-user@freebsd.org)
Received: from reviews.nyi.freebsd.org (reviews.nyi.freebsd.org
 [IPv6:2610:1c1:1:607c::16:b])
 by mx1.freebsd.org (Postfix) with ESMTP id 830E61A28
 for <freebsd-net@freebsd.org>; Wed, 18 May 2016 01:15:07 +0000 (UTC)
 (envelope-from daemon-user@freebsd.org)
Received: by reviews.nyi.freebsd.org (Postfix, from userid 1346)
 id 2DC0B1629A; Wed, 18 May 2016 01:15:07 +0000 (UTC)
Date: Wed, 18 May 2016 01:15:07 +0000
To: freebsd-net@freebsd.org
From: "sepherosa_gmail.com (Sepherosa Ziehau)" <phabric-noreply@FreeBSD.org>
Reply-to: D6406+325+76b767348064de43@reviews.freebsd.org
Subject: [Differential] D6406: mbuf: Add a flag for M_HASHTYPE_ to indicate
 the type has hash properties
Message-ID: <fa9e2e13cb0870d0ada5045012b6d970@localhost.localdomain>
X-Priority: 3
X-Phabricator-Sent-This-Message: Yes
X-Mail-Transport-Agent: MetaMTA
X-Auto-Response-Suppress: All
X-Phabricator-Mail-Tags: <differential-comment>
Thread-Topic: D6406: mbuf: Add a flag for M_HASHTYPE_ to indicate the type has
 hash properties
X-Herald-Rules: none
X-Phabricator-To: <PHID-USER-owbigh336siepsaab2ye>
X-Phabricator-To: <PHID-PROJ-62ihepuxzgyzg7rh5uic>
X-Phabricator-To: <PHID-USER-wmu3dipuua4kxljjqlii>
X-Phabricator-To: <PHID-USER-n3y55yy4j7xarsdk3otz>
X-Phabricator-To: <PHID-USER-xs5piezwnsa6epounp3t>
X-Phabricator-To: <PHID-USER-sfbxp2cksgub2ywlvupr>
X-Phabricator-To: <PHID-USER-ogl2udicsobdviqdulu3>
X-Phabricator-To: <PHID-USER-nb2boxugvmpo7syia5md>
X-Phabricator-To: <PHID-USER-ug3kdqciycpghwfscl6v>
X-Phabricator-To: <PHID-USER-3chbbds7jbl2e23f44bm>
X-Phabricator-Cc: <PHID-USER-mdwvnzzsrozqcmzhmbra>
X-Phabricator-Cc: <PHID-USER-dyyyzfp34mimhzvg33tk>
Precedence: bulk
In-Reply-To: <differential-rev-PHID-DREV-xuh5f6dfxihqp2pzh5pn-req@FreeBSD.org>
References: <differential-rev-PHID-DREV-xuh5f6dfxihqp2pzh5pn-req@FreeBSD.org>
Thread-Index: NTE3YjE0YWU1ZTZhYmMwODc0YTM1NDI5ZGZkIFc7whs=
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="utf-8"
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.22
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net/>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 18 May 2016 01:15:07 -0000

sepherosa_gmail.com added a comment.


  In https://reviews.freebsd.org/D6406#136037, @hselasky wrote:
  
  > What is the advantage of this bit versus a hash-type range check?
  
  
  Range check is not helpful.  Some drivers' OPAQUE flowid is actually RSS hash value (it just does not know the RSS hash type for some reasons).

REVISION DETAIL
  https://reviews.freebsd.org/D6406

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: sepherosa_gmail.com, #network, adrian, delphij, rwatson, gnn, glebius, rrs, bz, gallatin
Cc: hselasky, freebsd-net-list