From owner-cvs-all  Fri Oct 26  9:52: 3 2001
Delivered-To: cvs-all@freebsd.org
Received: from aldan.algebra.com (aldan.algebra.com [216.254.65.224])
	by hub.freebsd.org (Postfix) with ESMTP
	id 4DFC437B40C; Fri, 26 Oct 2001 09:51:50 -0700 (PDT)
Received: from aldan.algebra.com (localhost [127.0.0.1])
	by aldan.algebra.com (8.11.6/8.11.5) with ESMTP id f9QGnWa79416;
	Fri, 26 Oct 2001 12:49:33 -0400 (EDT)
	(envelope-from mi@aldan.algebra.com)
Message-Id: <200110261649.f9QGnWa79416@aldan.algebra.com>
Date: Fri, 26 Oct 2001 12:49:29 -0400 (EDT)
From: Mikhail Teterin <mi@aldan.algebra.com>
Subject: Re: cvs commit: ports/graphics/gd Makefile pkg-plist
To: roam@FreeBSD.org
Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
In-Reply-To: <200110261207.f9QC72K56756@freefall.freebsd.org>
MIME-Version: 1.0
Content-Type: TEXT/plain; charset=US-ASCII
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

On 26 Oct, Peter Pentchev wrote:
> roam        2001/10/26 05:07:02 PDT
> 
>   Modified files:
>     graphics/gd          Makefile pkg-plist 
>   Log:
>   Install the HTML documentation.

I think
	.if !defined(NOPORTDOCS)
	post-install:
		${MKDIR} ${DOCSDIR}
		${INSTALL_DATA} ${DOCS:S,^,${WRKSRC}/,} ${DOCSDIR}
	.endif

makes a better bikeshed than:

	post-install:
	.if !defined(NOPORTDOCS)
		${MKDIR} ${DOCSDIR}
		${INSTALL_DATA} ${DOCS:S,^,${WRKSRC}/,} ${DOCSDIR}
	.endif

Your variant keeps the empty post-install target in case of NOPORTDOCS.

But more importantly, please, do the same to gd2, which will eventually
replace gd...

	-mi



To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message