From owner-svn-src-all@FreeBSD.ORG Mon Oct 26 16:50:35 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 32E48106566C; Mon, 26 Oct 2009 16:50:35 +0000 (UTC) (envelope-from avg@freebsd.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id C0A2A8FC08; Mon, 26 Oct 2009 16:50:33 +0000 (UTC) Received: from odyssey.starpoint.kiev.ua (alpha-e.starpoint.kiev.ua [212.40.38.101]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id SAA04151; Mon, 26 Oct 2009 18:50:29 +0200 (EET) (envelope-from avg@freebsd.org) Message-ID: <4AE5D355.8020107@freebsd.org> Date: Mon, 26 Oct 2009 18:50:29 +0200 From: Andriy Gapon User-Agent: Thunderbird 2.0.0.23 (X11/20090825) MIME-Version: 1.0 To: Marcel Moolenaar References: <200910232253.n9NMr10R074584@svn.freebsd.org> <200910260837.23479.jhb@freebsd.org> <8082A638-C5BA-42F9-8C2E-DA31EF084840@mac.com> In-Reply-To: <8082A638-C5BA-42F9-8C2E-DA31EF084840@mac.com> X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, John Baldwin Subject: Re: svn commit: r198431 - head/sys/dev/pci X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Oct 2009 16:50:35 -0000 on 26/10/2009 18:32 Marcel Moolenaar said the following: > > The change was made because 1) doing this as part of the PCI code is > unnecessary for non-PC HW, and 2) it's entirely untested on non-PC > HW and the gratuitous change can therefore only do harm -- he, guess > what, it did do harm. > > Unless people fix the resource stuff this change cannot be reverted. Well, I think that maybe people who could fix this might not have the hardware that is need to reproduce and test the problem. So they need help of people who do have the hardware and can reproduce the problem. Perhaps, just disabling the code _and_ stopping there is what should not be done. > After the resource fix has gone in, I still object to this being > reverted on grounds of gratuitous code bloat. I say this with ARM, > MIPS and PowerPC/Book-E in mind. Well, PCI USB controller drivers would also have this bloat, but I am not sure if hardware for the platforms you listed has PCI *HCI controllers. Besides, only code execution is now disabled, the code itself is still present, which also can be considered as a form of bloat. Perhaps #if defined (arch1) ... would be more appropriate here? I am not sure. -- Andriy Gapon