From owner-freebsd-ports-bugs@FreeBSD.ORG Thu Mar 27 10:50:08 2008 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6871B1065670 for ; Thu, 27 Mar 2008 10:50:08 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 40F4F8FC38 for ; Thu, 27 Mar 2008 10:50:08 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m2RAo8br052738 for ; Thu, 27 Mar 2008 10:50:08 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m2RAo8Vi052338; Thu, 27 Mar 2008 10:50:08 GMT (envelope-from gnats) Resent-Date: Thu, 27 Mar 2008 10:50:08 GMT Resent-Message-Id: <200803271050.m2RAo8Vi052338@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Stefan Sperling Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4274A1065670 for ; Thu, 27 Mar 2008 10:45:04 +0000 (UTC) (envelope-from stsp@stsp.name) Received: from einhorn.in-berlin.de (einhorn.in-berlin.de [192.109.42.8]) by mx1.freebsd.org (Postfix) with ESMTP id C0CB78FC1B for ; Thu, 27 Mar 2008 10:45:03 +0000 (UTC) (envelope-from stsp@stsp.name) Received: from stsp.name (ted.stsp.name [217.197.84.186]) (authenticated bits=128) by einhorn.in-berlin.de (8.13.6/8.13.6/Debian-1) with ESMTP id m2RA9lAL006688 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT) for ; Thu, 27 Mar 2008 11:09:48 +0100 Received: from ted.stsp.name (localhost [127.0.0.1]) by stsp.name (8.14.2/8.14.2) with ESMTP id m2RABDXO014544 for ; Thu, 27 Mar 2008 11:11:13 +0100 (CET) (envelope-from stsp@ted.stsp.name) Received: (from stsp@localhost) by ted.stsp.name (8.14.2/8.14.2/Submit) id m2RABDFl014543; Thu, 27 Mar 2008 11:11:13 +0100 (CET) (envelope-from stsp) Message-Id: <200803271011.m2RABDFl014543@ted.stsp.name> Date: Thu, 27 Mar 2008 11:11:13 +0100 (CET) From: Stefan Sperling To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: ports/122151: www/gnome-keyring fails to build X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Stefan Sperling List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Mar 2008 10:50:08 -0000 >Number: 122151 >Category: ports >Synopsis: www/gnome-keyring fails to build >Confidential: no >Severity: serious >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Thu Mar 27 10:50:02 UTC 2008 >Closed-Date: >Last-Modified: >Originator: Stefan Sperling >Release: FreeBSD 6.3-RELEASE-p1 i386 >Organization: >Environment: System: FreeBSD ted.stsp.name 6.3-RELEASE-p1 FreeBSD 6.3-RELEASE-p1 #0: Sat Feb 16 13:49:01 CET 2008 stsp@ted.stsp.name:/usr/obj/home/stsp/src/freebsd-6.3-wol/sys/TED i386 >Description: security/gnome-keyring fails to build with this error: cc -DHAVE_CONFIG_H -I. -I.. -DPREFIX=\"/usr/local\" -DBINDIR=\"/usr/local/bin\" -DLIBEXECDIR=\"/usr/local/libexec\" -DGNOMELOCALEDIR=\"/usr/local/share/locale\" -I.. -I.. -I/usr/local/include/dbus-1.0 -I/usr/local/include/dbus-1.0/include -DGKR_DBUS_MAJOR_VERSION=1 -DGKR_DBUS_MINOR_VERSION=1 -DGKR_DBUS_MICRO_VERSION=20 -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -I/usr/local/include -O2 -fno-strict-aliasing -pipe -MT gnome-keyring.lo -MD -MP -MF .deps/gnome-keyring.Tpo -c gnome-keyring.c -fPIC -DPIC -o .libs/gnome-keyring.o gnome-keyring.c: In function `gnome_keyring_daemon_prepare_environment_sync': gnome-keyring.c:1792: error: `environ' undeclared (first use in this function) gnome-keyring.c:1792: error: (Each undeclared identifier is reported only once gnome-keyring.c:1792: error: for each function it appears in.) gmake[3]: *** [gnome-keyring.lo] Error 1 The code seems to assume that the global variabel 'environ' has already been declared somewhere -- it's cast to a const gchar**, which from looking at the glib headers is just a const char**. It looks like in FreeBSD code should explicitly declare extern char **environ; before using it, see environ(7). >How-To-Repeat: This happened to me first during 'portmaster -auD', and I can reproduce it by running: cd /usr/ports/security/gnome-keyring && make >Fix: I've added this patch and now it compiles, no idea if it runs, but I don't really care since this port just got pulled in as a dependency. I'll never really it use anyway. stsp@ted [gnome-keyring] $ cat files/patch-library_gnome-keyring.c --- library/gnome-keyring.c.orig 2008-03-27 10:50:03.000000000 +0100 +++ library/gnome-keyring.c 2008-03-27 11:06:27.000000000 +0100 @@ -1779,6 +1779,7 @@ gnome_keyring_daemon_set_display_sync (c * Return value: %GNOME_KEYRING_RESULT_OK if the operation was succcessful or * an error result otherwise. **/ +extern char **environ; GnomeKeyringResult gnome_keyring_daemon_prepare_environment_sync (void) { stsp@ted [gnome-keyring] $ >Release-Note: >Audit-Trail: >Unformatted: