From owner-cvs-all@FreeBSD.ORG Thu Jun 19 11:21:45 2003 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9F4B437B401; Thu, 19 Jun 2003 11:21:45 -0700 (PDT) Received: from mail.cyberonic.com (mail.cyberonic.com [4.17.179.4]) by mx1.FreeBSD.org (Postfix) with ESMTP id AABE843F75; Thu, 19 Jun 2003 11:21:43 -0700 (PDT) (envelope-from jmg@hydrogen.funkthat.com) Received: from hydrogen.funkthat.com (node-40244c0a.sfo.onnet.us.uu.net [64.36.76.10]) by mail.cyberonic.com (8.12.8/8.12.5) with ESMTP id h5JImGMo016347; Thu, 19 Jun 2003 14:48:17 -0400 Received: (from jmg@localhost) by hydrogen.funkthat.com (8.12.9/8.11.6) id h5JIMDf7076596; Thu, 19 Jun 2003 11:22:13 -0700 (PDT) (envelope-from jmg) Date: Thu, 19 Jun 2003 11:22:13 -0700 From: John-Mark Gurney To: Mike Silbersack Message-ID: <20030619182213.GB64061@funkthat.com> References: <200306181857.h5IIvwfY075070@repoman.freebsd.org> <20030619082713.GC79448@HAL9000.homeunix.com> <20030619115532.A629@odysseus.silby.com> <20030619150711.GA56423@fling-wing.demos.su> <20030619140309.H629@odysseus.silby.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030619140309.H629@odysseus.silby.com> User-Agent: Mutt/1.4.1i X-Operating-System: FreeBSD 4.2-RELEASE i386 X-PGP-Fingerprint: B7 EC EF F8 AE ED A7 31 96 7A 22 B3 D8 56 36 F4 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html cc: Dmitry Sivachenko cc: David Schultz cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org cc: cvs-src@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_descrip.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: John-Mark Gurney List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Jun 2003 18:21:46 -0000 Mike Silbersack wrote this message on Thu, Jun 19, 2003 at 14:03 -0500: > > On Thu, 19 Jun 2003, Dmitry Sivachenko wrote: > > > > Oh, btw; while running my fd hog program as root, cron decided to core. > > > Someone should take a look at it and figure out where it doesn't check the > > > return value of something which allocates a fd (or socket?) > > > > > > > bin/49096 ? > > That looks like it might be it, I'll give it a try and commit it if solves > the problem for me. Actually, that patch should be committed even if it doesn't solve the problem. The if (in == NULL) is useless since we already tried to read a char from it. -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."