From owner-freebsd-bugs@freebsd.org Thu Oct 8 19:27:00 2015 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C758C9D1561 for ; Thu, 8 Oct 2015 19:27:00 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 9A0CE2AE for ; Thu, 8 Oct 2015 19:27:00 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id t98JR0Gs010617 for ; Thu, 8 Oct 2015 19:27:00 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 203648] makefs: Coverity CID 1008927: sizeof() compared against desired bit count rather than byte count Date: Thu, 08 Oct 2015 19:27:00 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 11.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: scdbackup@gmx.net X-Bugzilla-Status: New X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Oct 2015 19:27:00 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=203648 Bug ID: 203648 Summary: makefs: Coverity CID 1008927: sizeof() compared against desired bit count rather than byte count Product: Base System Version: 11.0-CURRENT Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: bin Assignee: freebsd-bugs@FreeBSD.org Reporter: scdbackup@gmx.net usr.sbin/makefs/cd9660/iso9660_rrip.c CID 1008927: Operands don't affect result (CONSTANT_EXPRESSION_RESULT) result_independent_of_operands: (uint64_t)fnode->inode->st.st_dev >> 32 is 0 regardless of the values of its operands. This occurs as an argument to a function call. 660 cd9660_bothendian_dword((uint64_t)fnode->inode->st.st_dev >> 32, 661 pn_field->attr.rr_entry.PN.high); --------------- Source analysis: The complained statement is in an if case which obviously shall take care for 64-bit dev_t. But the test expression looks for 256-bit dev_t (which i doubt that it does exist anywhere). if (sizeof (fnode->inode->st.st_dev) > 32) cd9660_bothendian_dword((uint64_t)fnode->inode->st.st_dev >> 32, pn_field->attr.rr_entry.PN.high); else cd9660_bothendian_dword(0, pn_field->attr.rr_entry.PN.high); --------------- Remedy proposal: - if (sizeof (fnode->inode->st.st_dev) > 32) + if (sizeof (fnode->inode->st.st_dev) > 4) -- You are receiving this mail because: You are the assignee for the bug.