From owner-cvs-all  Thu Dec 20 14:50:35 2001
Delivered-To: cvs-all@freebsd.org
Received: from ns.yogotech.com (ns.yogotech.com [206.127.123.66])
	by hub.freebsd.org (Postfix) with ESMTP
	id 7E60637B416; Thu, 20 Dec 2001 14:50:28 -0800 (PST)
Received: from caddis.yogotech.com (caddis.yogotech.com [206.127.123.130])
	by ns.yogotech.com (8.9.3/8.9.3) with ESMTP id PAA14677;
	Thu, 20 Dec 2001 15:50:23 -0700 (MST)
	(envelope-from nate@yogotech.com)
Received: (from nate@localhost)
	by caddis.yogotech.com (8.11.6/8.11.6) id fBKMoBB67040;
	Thu, 20 Dec 2001 15:50:11 -0700 (MST)
	(envelope-from nate)
From: Nate Williams <nate@yogotech.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <15394.27427.220607.984244@caddis.yogotech.com>
Date: Thu, 20 Dec 2001 15:50:11 -0700
To: Poul-Henning Kamp <phk@critter.freebsd.dk>
Cc: Bruce Evans <bde@zeta.org.au>, Peter Wemm <peter@FreeBSD.org>,
	cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/alpha/alpha pmap.c src/sys/i386/i386 pmap.c src/sys/ia64/ia64 pmap.c 
In-Reply-To: <667.1008876572@critter.freebsd.dk>
References: <20011221005726.Q884-100000@gamplex.bde.org>
	<667.1008876572@critter.freebsd.dk>
X-Mailer: VM 6.96 under 21.1 (patch 14) "Cuyahoga Valley" XEmacs Lucid
Reply-To: nate@yogotech.com (Nate Williams)
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

> >> peter       2001/12/19 21:29:59 PST
> >>
> >>   Modified files:
> >>     sys/alpha/alpha      pmap.c
> >>     sys/i386/i386        pmap.c
> >>     sys/ia64/ia64        pmap.c
> >>   Log:
> >>   Replace a bunch of:
> >>         for (pv = TAILQ_FIRST(&m->md.pv_list);
> >>                  pv;
> >>                  pv = TAILQ_NEXT(pv, pv_list)) {
> >>   with:
> >>         TAILQ_FOREACH(pv, &m->md.pv_list, pv_list) {
> >>
> >>   Revision  Changes    Path
> >>   1.79      +9 -28     src/sys/alpha/alpha/pmap.c
> >>   1.301     +6 -20     src/sys/i386/i386/pmap.c
> >>   1.41      +10 -30    src/sys/ia64/ia64/pmap.c
> >
> >This is a regression IMO.  Please write C programs in something
> >resembling C.
> 
> This is an improvement IMO.  Please use whatever means we have to
> improve readability of our source code.

I agree with Bruce.  It reduces readability because it requires
implicit knowledge of the (IMHO) incredibly confusing QUEUE macros.

The original code is more C-like, and is easier to understand.


Nate

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message