From owner-freebsd-hackers@FreeBSD.ORG Tue Dec 11 02:52:51 2012 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 40F12C1B; Tue, 11 Dec 2012 02:52:51 +0000 (UTC) (envelope-from jhs@berklix.com) Received: from slim.berklix.org (slim.berklix.org [94.185.90.68]) by mx1.freebsd.org (Postfix) with ESMTP id AF95C8FC15; Tue, 11 Dec 2012 02:52:49 +0000 (UTC) Received: from mart.js.berklix.net (pD9FBFB06.dip.t-dialin.net [217.251.251.6]) (authenticated bits=128) by slim.berklix.org (8.14.5/8.14.5) with ESMTP id qBB2qfT7061374; Tue, 11 Dec 2012 03:52:42 +0100 (CET) (envelope-from jhs@berklix.com) Received: from fire.js.berklix.net (fire.js.berklix.net [192.168.91.41]) by mart.js.berklix.net (8.14.3/8.14.3) with ESMTP id qBB2qen9019919; Tue, 11 Dec 2012 03:52:41 +0100 (CET) (envelope-from jhs@berklix.com) Received: from fire.js.berklix.net (localhost [127.0.0.1]) by fire.js.berklix.net (8.14.4/8.14.4) with ESMTP id qBB2qXZS041825; Tue, 11 Dec 2012 03:52:39 +0100 (CET) (envelope-from jhs@fire.js.berklix.net) Message-Id: <201212110252.qBB2qXZS041825@fire.js.berklix.net> To: "Greg 'groggy' Lehey" Subject: Re: calendar(1) regressions From: "Julian H. Stacey" Organization: http://berklix.com BSD Unix Linux Consultancy, Munich Germany User-agent: EXMH on FreeBSD http://berklix.com/free/ X-URL: http://www.berklix.com In-reply-to: Your message "Tue, 11 Dec 2012 10:04:52 +1100." <20121210230452.GE36593@eureka.lemis.com> Date: Tue, 11 Dec 2012 03:52:32 +0100 Sender: jhs@berklix.com Cc: Jaakko Heinonen , edwin@freebsd.org, freebsd-hackers@freebsd.org X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Dec 2012 02:52:51 -0000 "Greg 'groggy' Lehey" wrote: > > --cHMo6Wbp1wrKhbfi > Content-Type: text/plain; charset=us-ascii > Content-Disposition: inline > > On Monday, 10 December 2012 at 16:27:39 +0200, Jaakko Heinonen wrote: > > > > Hi! > > > > On 2012-12-10, Greg 'groggy' Lehey wrote: > >>> Unfortunately r205821 [1] has caused several regressions to calendar(1). > >>> Relevant PRs: > >>> > >>> bin/157718 > >>> bin/162211 > >>> bin/168785 > >>> bin/170930 > >> > >> I think we fix bugs rather than revert the commits. > > > > Of course it's preferred but I didn't see any progress happening. As a > > result some of the basic functionality is broken (especially in > > stable/8). Maybe I should have debugged and fixed those bugs but I > > wasn't really keen to debug a large commit adding mostly features which > > I don't care much. > > IIRC the main issue in 8 was that debug output was appearing as a > matter of course. It would be relatively trivial to MF9 (i.e. copy > the 9-STABLE version), but of course that would only solve part of the > problem. Do you want an MFC to 8 when I'm done? > > Greg > -- > Sent from my desktop computer. > Finger grog@FreeBSD.org for PGP public key. > See complete headers for address and phone numbers. > This message is digitally signed. If your Microsoft MUA reports > problems, please read http://tinyurl.com/broken-mua > Hi Greg I too filed send-prs re. rgeression bugs in recent broken calendar, hopefully you can look/ fix please. http://www.berklix.com/~jhs/src/bsd/fixes/FreeBSD/src/gen/usr.bin/calendar/REAME.JHS bin/15182 http://www.berklix.com/~jhs/src/bsd/fixes/FreeBSD/src/gen/usr.bin/calendar/send-pr.impossible_date.no_customise bin/157718 http://www.berklix.com/~jhs/src/bsd/fixes/FreeBSD/src/gen/usr.bin/calendar/core_dump_shell.no_customise bin/162211 http://www.berklix.com/~jhs/src/bsd/fixes/FreeBSD/src/gen/usr.bin/calendar/send-pr.first_last_in_month.no_customise -------------- PS for Anyone, doesnt need to be Greg misc/157748 This PR is NOT a regression coding error, but corrections & additions for a lot of badly sorted & incorrect src/ data in wrong calendar files etc. It doesn't need a programmer to fix it, any commiter could make corrections & also someone with a sense of orthogonality could shuffle data around, as some current calendar data in src/ is in wrong files, & also in some cases date is wrong. http://www.berklix.com/~jhs/src/bsd/fixes/FreeBSD/src/gen/usr.bin/calendar/calendars/calendar.holiday.send-pr http://www.berklix.com/~jhs/src/bsd/fixes/FreeBSD/src/gen/usr.bin/calendar/calendars/ Cheers, Julian -- Julian Stacey, BSD Unix Linux C Sys Eng Consultant, Munich http://berklix.com Reply below not above, like a play script. Indent old text with "> ". Send plain text. Not: HTML, multipart/alternative, base64, quoted-printable.