From owner-freebsd-current@FreeBSD.ORG  Mon Sep 27 15:53:06 2010
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id E6BD21065672
	for <current@freebsd.org>; Mon, 27 Sep 2010 15:53:06 +0000 (UTC)
	(envelope-from julian@freebsd.org)
Received: from out-0.mx.aerioconnect.net (out-0-17.mx.aerioconnect.net
	[216.240.47.77])
	by mx1.freebsd.org (Postfix) with ESMTP id C9E158FC1A
	for <current@freebsd.org>; Mon, 27 Sep 2010 15:53:06 +0000 (UTC)
Received: from idiom.com (postfix@mx0.idiom.com [216.240.32.160])
	by out-0.mx.aerioconnect.net (8.13.8/8.13.8) with ESMTP id
	o8RFr5Kc024993; Mon, 27 Sep 2010 08:53:05 -0700
X-Client-Authorized: MaGic Cook1e
X-Client-Authorized: MaGic Cook1e
X-Client-Authorized: MaGic Cook1e
Received: from julian-mac.elischer.org
	(h-67-100-89-137.snfccasy.static.covad.net [67.100.89.137])
	by idiom.com (Postfix) with ESMTP id D86BF2D6013;
	Mon, 27 Sep 2010 08:53:03 -0700 (PDT)
Message-ID: <4CA0BE08.50408@freebsd.org>
Date: Mon, 27 Sep 2010 08:53:44 -0700
From: Julian Elischer <julian@freebsd.org>
User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X 10.4; en-US;
	rv:1.9.2.9) Gecko/20100915 Thunderbird/3.1.4
MIME-Version: 1.0
To: sbruno@freebsd.org
References: <1285601161.7245.7.camel@home-yahoo>
In-Reply-To: <1285601161.7245.7.camel@home-yahoo>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Scanned-By: MIMEDefang 2.67 on 216.240.47.51
Cc: Sean Bruno <seanbru@yahoo-inc.com>,
	"current@freebsd.org" <current@freebsd.org>
Subject: Re: MAXCPU preparations
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 27 Sep 2010 15:53:07 -0000

  On 9/27/10 8:26 AM, Sean Bruno wrote:
> Does this look like an appropriate modification to libmemstat?
>
> Sean
>
>
> ==== //depot/yahoo/ybsd_7/src/lib/libmemstat/memstat.h#4
> - /home/seanbru/ybsd_7/src/lib/libmemstat/memstat.h ====
> @@ -28,12 +28,13 @@
>
>   #ifndef _MEMSTAT_H_
>   #define        _MEMSTAT_H_
> +#include<sys/param.h>
>
>   /*
>    * Number of CPU slots in library-internal data structures.  This
> should be
>    * at least the value of MAXCPU from param.h.
>    */
> -#define        MEMSTAT_MAXCPU  64
> +#define        MEMSTAT_MAXCPU  MAXCPU /* defined in
> sys/${ARCH}/include/param.h */
>


wouldn't it be better to do a sysctlbyname() and use the real value 
for the system?

>   /*
>    * Amount of caller data to maintain for each caller data slot.
> Applications
>
>
> _______________________________________________
> freebsd-current@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-current
> To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"
>