From owner-cvs-all@FreeBSD.ORG  Wed Nov 30 09:20:40 2005
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id A5F7016A41F;
	Wed, 30 Nov 2005 09:20:40 +0000 (GMT)
	(envelope-from rwatson@FreeBSD.org)
Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 51F4543D8C;
	Wed, 30 Nov 2005 09:20:30 +0000 (GMT)
	(envelope-from rwatson@FreeBSD.org)
Received: from fledge.watson.org (fledge.watson.org [209.31.154.41])
	by cyrus.watson.org (Postfix) with ESMTP id B925646B2D;
	Wed, 30 Nov 2005 04:20:27 -0500 (EST)
Date: Wed, 30 Nov 2005 09:20:27 +0000 (GMT)
From: Robert Watson <rwatson@FreeBSD.org>
X-X-Sender: robert@fledge.watson.org
To: John Baldwin <jhb@FreeBSD.org>
In-Reply-To: <200511292307.jATN7EJH055853@repoman.freebsd.org>
Message-ID: <20051130091930.K95395@fledge.watson.org>
References: <200511292307.jATN7EJH055853@repoman.freebsd.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/kern uipc_socket.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 30 Nov 2005 09:20:40 -0000


On Tue, 29 Nov 2005, John Baldwin wrote:

>  Fix snderr() to not leak the socket buffer lock if an error occurs in
>  sosend().  Robert accidentally changed the snderr() macro to jump to the
>  out label which assumes the lock is already released rather than the
>  release label which drops the lock in his previous change to sosend().
>  This should fix the recent panics about returning from write(2) with the
>  socket lock held and the most recent LOR on current@.

Thanks for fixing this -- I ran this patch in testing for ages, but must 
have done some "clean up" or other such 99.85% harmless activity :-(.

Robert N M Watson