From owner-freebsd-ports@FreeBSD.ORG Sun Jun 15 15:21:30 2014 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 3D520971 for ; Sun, 15 Jun 2014 15:21:30 +0000 (UTC) Received: from smtp.infracaninophile.co.uk (smtp6.infracaninophile.co.uk [IPv6:2001:8b0:151:1:3cd3:cd67:fafa:3d78]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "smtp.infracaninophile.co.uk", Issuer "ca.infracaninophile.co.uk" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id B260B230A for ; Sun, 15 Jun 2014 15:21:29 +0000 (UTC) Received: from seedling.black-earth.co.uk (seedling.black-earth.co.uk [81.2.117.99]) (authenticated bits=0) by smtp.infracaninophile.co.uk (8.14.8/8.14.8) with ESMTP id s5FFLLfk047575 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Sun, 15 Jun 2014 16:21:22 +0100 (BST) (envelope-from matthew@FreeBSD.org) Authentication-Results: lucid-nonsense.infracaninophile.co.uk; dmarc=none header.from=FreeBSD.org DKIM-Filter: OpenDKIM Filter v2.8.3 smtp.infracaninophile.co.uk s5FFLLfk047575 Authentication-Results: smtp.infracaninophile.co.uk/s5FFLLfk047575; dkim=none reason="no signature"; dkim-adsp=none Message-ID: <539DB9DD.3050603@FreeBSD.org> Date: Sun, 15 Jun 2014 16:21:01 +0100 From: Matthew Seaman User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: freebsd-ports@freebsd.org, michelle@sorbs.net, lists@opsec.eu Subject: Re: ports/189880: port pgpool-II out of date. References: <201405170220.s4H2K0G0085365@freefall.freebsd.org> <538D0AAE.7090800@sorbs.net> <20140615111101.GM2341@home.opsec.eu> <539DA4F3.2060004@sorbs.net> <20140615142903.GQ2341@home.opsec.eu> In-Reply-To: <20140615142903.GQ2341@home.opsec.eu> X-Enigmail-Version: 1.6 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="MWUGIb48Rl2P6fL6RARplDi20uNVU9lCo" X-Virus-Scanned: clamav-milter 0.98.3 at lucid-nonsense.infracaninophile.co.uk X-Virus-Status: Clean X-Spam-Status: No, score=-3.1 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham autolearn_force=no version=3.4.0 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lucid-nonsense.infracaninophile.co.uk X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Jun 2014 15:21:30 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --MWUGIb48Rl2P6fL6RARplDi20uNVU9lCo Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Heh. I was just starting to look at writing a pgpool-II-33 port, but it seems you have beaten me to it. On 15/06/2014 15:29, Kurt Jaeger wrote: > Hi! >=20 >>> Second step: merging the diverse set of pgpool related ports into one= ? >=20 >> Maybe pg-pool-II and pg-pool-devel...? (3.1/2 in stable and 3.3 in >> devel - until it changes?) pgpool-II has 3 stable releases at the moment 3.1.10, 3.2.8, 3.3.3 which are all still receiving updates. > I assume that all the pgpool ports can be consolidated into one (3.3). >=20 > Maybe if we start by DEPRECATing the old ones to find out who > still wants them ? Bcc to kuriyama... There's a number of things wrong with this port, some inherited from the pgpool-II port you copied, and some where you're using outmoded construct= s. - You should probably have USES+=3Dpgsql and WANT_PGSQL=3Dclient rath= er than USE_PGSQL. - You don't need the empty CONFIGURE_ARGS=3D and LIB_DEPENDS=3D assignments. - Install docs unconditionally to staging rather than examining the state of the DOCS option. Whether docs get installed finally is handled in the post-staging steps. - Use options helpers rather than if $(PORT_OPTIONS:MFoo). Eg. instead of =2Eif ${PORT_OPTIONS:MSSL} USE_OPENSSL=3D yes CONFIGURE_ARGS+=3D--with-openssl =2Eendif use: SSL_CONFIGURE_WITH=3D openssl SSL_USE=3D OPENSSL=3DYES and similarly for the PAM option. (You used helpers for LIBMEMCACHED stuff but not the others?) You can then dispense with '.include ' line - The port cannot be staged as a non-root user. This is due to the way the contrib Makefiles are written -- although elsewhere it uses standard autoconf stuff, which pretty much just works for staging purposes. Probably the best way to fix this is to use ${INSTALL_LIB} or ${INSTALL_DATA} directly from the port's Makefile and bypass that install target entirely. It's only 6 files in total affected by this. - The .if exists(...) section has the same effect in either branch of the .if statement. You can just make that bit unconditional - There's a duplicated entry in the CONFLICTS line - portlint complains about the wrong sort of whitespace in the WWW: line in pkg-descr - You can make libtool automatically strip shared libraries on installation by adding: MAKE_ENV=3D INSTALL_STRIP_FLAG=3D${STRIP} This respects local debug settings, so users can build and install an unstripped version if they so desire. Cheers, Matthew --=20 Dr Matthew J Seaman MA, D.Phil. PGP: http://www.infracaninophile.co.uk/pgpkey --MWUGIb48Rl2P6fL6RARplDi20uNVU9lCo Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.20 (Darwin) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQJ8BAEBCgBmBQJTnbnwXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ2NTNBNjhCOTEzQTRFNkNGM0UxRTEzMjZC QjIzQUY1MThFMUE0MDEzAAoJELsjr1GOGkATrRgP/1o3BiJAnRxxsObr7d/GBSb1 cTZ3QSYgKPDga4t+S8oB0OHYDhYIXCnZ3Jo+OWBYeYb06P16DweNrlWTCNR7+xwf LomvjMR1mMz8cWkyPfhZdgy0/MFqxtiFdc+vmsi232Xeg7jfoBrIj4PySm5tfjS0 DopJGfQy7V+wvO8GnndUTwQgc/gFrimq3vh6wQRL9gBuiHfZhr79fltOWI2XDMdU s0RmrO/8VdlPQ/pdfywmONwyJ1pD3eZCT3A/MtwIjOWp841FZX4LqOZaoVs7Hqda TeQPcRSaNsJXFmyICK/LWQw3BXBVDmMZVjSq4IiFQOoISOExeADzlNI3LHVK7/Qp AdY/DRIvZQSvaaGfOP4J9kBsA9cVbqJegobAoFCdUdmin/fRpu3NWyCTj3WPjkhj iqYVon9m7ft5hKFFXxTpWHxsAwdXgl5Pdly4lKym5ZQZpkYoLbcAu6ZrPGKIwKCP ghGRIWAG5USw81ughgnwX03LFUbufCscCHyruqIDXTKJoy50wMGF8NSGobuX4oxR DuPfTUGFD0jLUc1GfZ7SnUdUqKTOR0U1kNHyS3lTGLP94Bv3O6+prwycMPztfrZT vr1aPblOa0ajy358YbdQzgLfUFjlsWE/0TijdLDNhMmpDbabJ/38dWRFnKOFxvb3 0jZ7QbPVuxceYEKfPf6o =phqV -----END PGP SIGNATURE----- --MWUGIb48Rl2P6fL6RARplDi20uNVU9lCo--