From owner-freebsd-gnome@FreeBSD.ORG Wed Feb 27 00:40:07 2008 Return-Path: Delivered-To: freebsd-gnome@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0A3ED106566C for ; Wed, 27 Feb 2008 00:40:07 +0000 (UTC) (envelope-from c11h15no2@yahoo.com) Received: from web30007.mail.mud.yahoo.com (web30007.mail.mud.yahoo.com [209.191.69.24]) by mx1.freebsd.org (Postfix) with SMTP id CB4F213C44B for ; Wed, 27 Feb 2008 00:40:06 +0000 (UTC) (envelope-from c11h15no2@yahoo.com) Received: (qmail 27050 invoked by uid 60001); 27 Feb 2008 00:40:06 -0000 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.com; h=X-YMail-OSG:Received:Date:From:Reply-To:Subject:To:Cc:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-ID; b=cKaeUbV5RxhWDzG2Y9aOCYz6p6kDHUIJefAGhS/AOGlzikU5aqE6zk+SM78/Z16D6hP0kYYusJFbTmsXXquaDSmGdV/Vmwe5qwbDCqo7OE6b3azi2jBPUD8JXsprC8SohiJV1BqJ1qrEKAg6ZA/PQ9YiqspfKXccr+qAK36IW8k=; X-YMail-OSG: D3ozEl8VM1n0IcuGwO_0pEi06DZdeN.X15TBbyJQfKB5mvGx3AbYgux5pke0PSbEqspuJDeMkhICQfuvy8BTzHV63KdJfWtdpPdTp_jPTxqlvzM- Received: from [12.216.99.19] by web30007.mail.mud.yahoo.com via HTTP; Tue, 26 Feb 2008 16:40:05 PST Date: Tue, 26 Feb 2008 16:40:05 -0800 (PST) From: Amatus To: Joe Marcus Clarke In-Reply-To: <1204071417.28361.87.camel@shumai.marcuscom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Message-ID: <994045.25676.qm@web30007.mail.mud.yahoo.com> Cc: freebsd-gnome@freebsd.org Subject: Re: Question about updating guile to 1.8 X-BeenThere: freebsd-gnome@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: amatus@gnu.org List-Id: GNOME for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Feb 2008 00:40:07 -0000 --- Joe Marcus Clarke wrote: > > On Tue, 2008-02-26 at 15:54 -0800, Amatus wrote: > > --- Joe Marcus Clarke wrote: > > > > > > > > On Mon, 2008-02-25 at 14:28 -0800, Amatus wrote: > > > > --- Joe Marcus Clarke wrote: > > > > > > > > > > > > > > On Mon, 2008-02-25 at 08:38 -0800, Amatus wrote: > > > > > > --- Joe Marcus Clarke wrote: > > > > > > > > > > > > > The way you're doing it is probably best. The way you > > > submitted > > > > > in > > > > > > > the > > > > > > > PR, while it may look correct, will most likely break > INDEX > > > when > > > > > > > guile > > > > > > > is not installed. Try it. Uninstall guile, then cd to > > > > > lang/slib, > > > > > > > and > > > > > > > run "make describe". Use of != is discouraged for > commands > > > which > > > > > are > > > > > > > not in the base system. > > > > > > > > > > > > > > Joe > > > > > > > > > > > > I uninstalled guile and make describe worked fine with some > > > noise > > > > > on > > > > > > stderr. > > > > > > > > > > What output? Any output on stderr is bad. > > > > > > > > The "make describe" outputs "/usr/local/bin/guile-config: not > > > found" on > > > > stderr as you might expect and the exit code is 0. Since "make > > > index" > > > > pipes stdout to the INDEX file everything should work fine, > just > > > some > > > > uglyness on the user's screen. If it's really important I can > try > > > 2> > > > > /dev/null in the command or maybe a test -f to see if the file > > > exists > > > > first. > > > > > > The bigger problem is what happens to the make describe output? > If > > > you > > > are not trying to use GUILE_VERSION in other make variables, I > would > > > skip the != notation, and use the previous `...` notation as it > is > > > safer. If you use !=, and the make variables that reference > > > GUILE_VERSION are used to in things like *_DEPENDS, then that > will > > > effectively break INDEX and package builds. > > > > > > Joe > > > > > > > I don't understand what the problem is. The "make describe" output > on > > stdout is perfectly fine, the return code is 0, and stderr goes to > the > > user's screen. The != is necessary as far as I can tell for use in > > PLIST_SUB. Though to get rid of the message on stderr I can do: > > Take this for instance: > > BUILD_DEPENDS= ${LOCALBASE}/share/${GUILE_VERSION}/...: > ${PORTSDIR}/lang/guile > > GUILE_VERSION!= ... > > If guile is not installed (e.g. when pointyhat builds INDEX or > prepares > a portbuild) then BUILD_DEPENDS is set to: > > ${LOCALBASE}/share//...:${PORTSDIR}/lang/guile > > And that will cause things to fail. All commands must succeed and > produce the correct output regardless of whether or not guile is > installed. > I wasn't planning on using GUILE_VER in *_DEPENDS anyway. If you guys want things hardcoded then I'll submit a super-patch including all the changes. > > > > GUILE_VER!=${TEST} -e ${LOCALBASE}/bin/guile-config && > > ${LOCALBASE}/bin/guile-config info guileversion | ${CUT} -f 1-2 -d > . || > > : > > While this solves the problem of keeping stderr clean, it will not > satisfy the requirements above. > > Joe ____________________________________________________________________________________ Be a better friend, newshound, and know-it-all with Yahoo! Mobile. Try it now. http://mobile.yahoo.com/;_ylt=Ahu06i62sR8HDtDypao8Wcj9tAcJ