From owner-cvs-all Thu May 30 8: 1:51 2002 Delivered-To: cvs-all@freebsd.org Received: from mail.speakeasy.net (mail13.speakeasy.net [216.254.0.213]) by hub.freebsd.org (Postfix) with ESMTP id 3B37C37B400 for ; Thu, 30 May 2002 08:00:38 -0700 (PDT) Received: (qmail 19513 invoked from network); 30 May 2002 15:00:36 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) by mail13.speakeasy.net (qmail-ldap-1.03) with DES-CBC3-SHA encrypted SMTP for ; 30 May 2002 15:00:36 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.11.6/8.11.6) with ESMTP id g4UF0pF32720; Thu, 30 May 2002 11:00:51 -0400 (EDT) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.2 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <20020529234552.A62266@dragon.nuxi.com> Date: Thu, 30 May 2002 11:00:17 -0400 (EDT) From: John Baldwin To: "David O'Brien" Subject: Re: cvs commit: src/contrib/gcc/config/i386 i386.h Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org, Alfred Perlstein Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 30-May-2002 David O'Brien wrote: > On Wed, May 29, 2002 at 11:39:43PM -0700, Alfred Perlstein wrote: >> Also I don't see the point of being so damn vague with your commits >> to the source tree. > > I believe a commit message should tell the why, not the way, the diff > gives that. You can always follow up with an e-mail reply to explain what the practical implications are, something like "This turns off the i386 #define, you should only be using __i386__." or something for us ignorant masses who don't know what the log message means. :) I think that is all Alfred is asking for here. >> You do want help right? > > I (and the other committer that prompted me to desire this change) would > like the world not to do "#ifdef i386". Any slothing you can give to > make this possible is appreciated. > "find . -type f | xargs egrep 'def.*i386' | grep -v __i386__" didn't show > anything for me. Alfred has been running around fixing these yesterday and last night so it seems he is helping, no need to jump on his case. I think his point is more that he would appreciate if you had follow up replies or something that helped explain what the changes were doing in a practical sense to help other folks start to grok gcc so they can help take over maintaining it. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message