From owner-freebsd-current@FreeBSD.ORG  Thu Aug  5 15:01:39 2004
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id D012C16A4CE
	for <freebsd-current@FreeBSD.org>;
	Thu,  5 Aug 2004 15:01:39 +0000 (GMT)
Received: from fledge.watson.org (fledge.watson.org [204.156.12.50])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 902E543D45
	for <freebsd-current@FreeBSD.org>;
	Thu,  5 Aug 2004 15:01:39 +0000 (GMT)
	(envelope-from robert@fledge.watson.org)
Received: from fledge.watson.org (localhost [127.0.0.1])
	by fledge.watson.org (8.12.11/8.12.11) with ESMTP id i75F0KnR035243;
	Thu, 5 Aug 2004 11:00:20 -0400 (EDT)
	(envelope-from robert@fledge.watson.org)
Received: from localhost (robert@localhost)i75F0Kpl035240;
	Thu, 5 Aug 2004 11:00:20 -0400 (EDT)
	(envelope-from robert@fledge.watson.org)
Date: Thu, 5 Aug 2004 11:00:20 -0400 (EDT)
From: Robert Watson <rwatson@FreeBSD.org>
X-Sender: robert@fledge.watson.org
To: Jun Kuriyama <kuriyama@imgsrc.co.jp>
In-Reply-To: <7mu0vhmzfs.wl@black.imgsrc.co.jp>
Message-ID: <Pine.NEB.3.96L.1040805105956.19039a-100000@fledge.watson.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: Current <freebsd-current@FreeBSD.org>
Subject: Re: panic: mutex inp not owned at
	/usr/src/sys/netinet/tcp_output.c:140
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 05 Aug 2004 15:01:39 -0000


On Thu, 5 Aug 2004, Jun Kuriyama wrote:

> At Thu, 5 Aug 2004 09:43:41 -0400 (EDT),
> Robert Watson wrote:
> > Could you try the attached patch?  This modifies the IPv6 code to match
> > the IPv4 code in passing in the "inpcbinfo" reference for a protocol,
> > rather than just its inpcb list.  This allows in6_pcbnotify() to lock the
> > structure before walking it.  It also acquires the per-pcb locks before
> > notifying each pcb of an event.
> 
> Can I have more patch?

==== //depot/user/rwatson/netperf/sys/netinet/tcp_subr.c#17 - /home/rwatson/p4/rwatson_netperf/sys/netinet/tcp_subr.c ====
@@ -1236,7 +1236,7 @@
 		bzero(&th, sizeof(th));
 		m_copydata(m, off, sizeof(*thp), (caddr_t)&th);
 
-		in6_pcbnotify(&tcb, sa, th.th_dport,
+		in6_pcbnotify(&tcbinfo, sa, th.th_dport,
 		    (struct sockaddr *)ip6cp->ip6c_src,
 		    th.th_sport, cmd, NULL, notify);
 
@@ -1247,7 +1247,7 @@
 		inc.inc_isipv6 = 1;
 		syncache_unreach(&inc, &th);
 	} else
-		in6_pcbnotify(&tcb, sa, 0, (const struct sockaddr *)sa6_src,
+		in6_pcbnotify(&tcbinfo, sa, 0, (const struct sockaddr *)sa6_src,
 			      0, cmd, NULL, notify);
 }
 #endif /* INET6 */