From owner-freebsd-current@FreeBSD.ORG Mon Mar 4 07:35:26 2013 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 44C025B5 for ; Mon, 4 Mar 2013 07:35:26 +0000 (UTC) (envelope-from c.jayachandran@gmail.com) Received: from mail-la0-x235.google.com (mail-la0-x235.google.com [IPv6:2a00:1450:4010:c03::235]) by mx1.freebsd.org (Postfix) with ESMTP id A3D9AFC for ; Mon, 4 Mar 2013 07:35:25 +0000 (UTC) Received: by mail-la0-f53.google.com with SMTP id fr10so4619689lab.40 for ; Sun, 03 Mar 2013 23:35:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:sender:date:x-google-sender-auth:message-id :subject:from:to:content-type; bh=eT70pzG7ZbyvbnSMq6Bjv0ZZksmpDgbg0Nwv7Kgoms0=; b=d2t3J6j6yTiBzKVPlK9Gtj863n8p3Wn5r/3hPo9GUJqDWUOAVs1+b9z73NeuSHrV7d pWZdQiwilaA1TeyjdJR+e346GcvTAo/S/tT1Dnx6p9LzIiB3yD8TImxNYcf3V5hHujxY I/PdnIB0wTs4U20OANt9TtFg3UTbd4z482sw08VcNfoNcIwHw+TvayRuP1NEZT2ppB8C 678hqWu90pCKM5UBNBSj5vyzZdZ5kqVvNFvGHlPz52ATgynOpdcAiQNNfehOAUCC5sxO tTi4v8tXMVH2CghZDe5m58sumPj6EJZWdzBxCuQaShbRkqpZy81i/CYjVbKcfGfyxRtx LsbA== MIME-Version: 1.0 X-Received: by 10.152.110.6 with SMTP id hw6mr17053221lab.43.1362382524634; Sun, 03 Mar 2013 23:35:24 -0800 (PST) Sender: c.jayachandran@gmail.com Received: by 10.112.51.6 with HTTP; Sun, 3 Mar 2013 23:35:24 -0800 (PST) Date: Mon, 4 Mar 2013 13:05:24 +0530 X-Google-Sender-Auth: dT3QozX76VABnJeLSz4oK5dY8Mg Message-ID: Subject: [PATCH] kenv issue when there is no static environment From: "Jayachandran C." To: FreeBSD Current Content-Type: multipart/mixed; boundary=bcaec54b48d06ddddd04d71466c4 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Mar 2013 07:35:26 -0000 --bcaec54b48d06ddddd04d71466c4 Content-Type: text/plain; charset=ISO-8859-1 Planning to check the attached patch later this week, please let me know if there any objections. ---- In case where there are no static kernel environment entries, the function init_dynamic_kenv() adds an incorrect entry at position 0 of the dynamic kernel environment. This entry is usually empty and confuses kenv(1). The entries added later by kenv(1) does not seem to be added, even though they are. The environment passed to the kernel can be empty when it is loaded from a bootloader other than loader(8). JC. --bcaec54b48d06ddddd04d71466c4 Content-Type: application/octet-stream; name="kenv-fix.patch" Content-Disposition: attachment; filename="kenv-fix.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hdvbcwrf0 SW5kZXg6IHN5cy9rZXJuL2tlcm5fZW52aXJvbm1lbnQuYwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBzeXMva2Vy bi9rZXJuX2Vudmlyb25tZW50LmMJKHJldmlzaW9uIDI0Nzc2NSkKKysrIHN5cy9rZXJuL2tlcm5f ZW52aXJvbm1lbnQuYwkod29ya2luZyBjb3B5KQpAQCAtMjMxLDIwICsyMzEsMjMgQEAgaW5pdF9k eW5hbWljX2tlbnYodm9pZCAqZGF0YSBfX3VudXNlZCkKIAlrZW52cCA9IG1hbGxvYygoS0VOVl9T SVpFICsgMSkgKiBzaXplb2YoY2hhciAqKSwgTV9LRU5WLAogCQlNX1dBSVRPSyB8IE1fWkVSTyk7 CiAJaSA9IDA7Ci0JZm9yIChjcCA9IGtlcm5fZW52cDsgY3AgIT0gTlVMTDsgY3AgPSBrZXJuZW52 X25leHQoY3ApKSB7Ci0JCWxlbiA9IHN0cmxlbihjcCkgKyAxOwotCQlpZiAobGVuID4gS0VOVl9N TkFNRUxFTiArIDEgKyBLRU5WX01WQUxMRU4gKyAxKSB7Ci0JCQlwcmludGYoIldBUk5JTkc6IHRv byBsb25nIGtlbnYgc3RyaW5nLCBpZ25vcmluZyAlc1xuIiwKLQkJCSAgICBjcCk7Ci0JCQljb250 aW51ZTsKKwlpZiAoZW52X3BvcyA+IDApIHsKKwkJZm9yIChjcCA9IGtlcm5fZW52cDsgY3AgIT0g TlVMTDsgY3AgPSBrZXJuZW52X25leHQoY3ApKSB7CisJCQlsZW4gPSBzdHJsZW4oY3ApICsgMTsK KwkJCWlmIChsZW4gPiBLRU5WX01OQU1FTEVOICsgMSArIEtFTlZfTVZBTExFTiArIDEpIHsKKwkJ CQlwcmludGYoCisJCQkJIldBUk5JTkc6IHRvbyBsb25nIGtlbnYgc3RyaW5nLCBpZ25vcmluZyAl c1xuIiwKKwkJCQkgICAgY3ApOworCQkJCWNvbnRpbnVlOworCQkJfQorCQkJaWYgKGkgPCBLRU5W X1NJWkUpIHsKKwkJCQlrZW52cFtpXSA9IG1hbGxvYyhsZW4sIE1fS0VOViwgTV9XQUlUT0spOwor CQkJCXN0cmNweShrZW52cFtpKytdLCBjcCk7CisJCQl9IGVsc2UKKwkJCQlwcmludGYoCisJCQkJ IldBUk5JTkc6IHRvbyBtYW55IGtlbnYgc3RyaW5ncywgaWdub3JpbmcgJXNcbiIsCisJCQkJICAg IGNwKTsKIAkJfQotCQlpZiAoaSA8IEtFTlZfU0laRSkgewotCQkJa2VudnBbaV0gPSBtYWxsb2Mo bGVuLCBNX0tFTlYsIE1fV0FJVE9LKTsKLQkJCXN0cmNweShrZW52cFtpKytdLCBjcCk7Ci0JCX0g ZWxzZQotCQkJcHJpbnRmKAotCQkJICAgICJXQVJOSU5HOiB0b28gbWFueSBrZW52IHN0cmluZ3Ms IGlnbm9yaW5nICVzXG4iLAotCQkJICAgIGNwKTsKIAl9CiAJa2VudnBbaV0gPSBOVUxMOwogCg== --bcaec54b48d06ddddd04d71466c4--