From owner-freebsd-ports@FreeBSD.ORG Sun Aug 8 07:32:07 2010 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C07661065670 for ; Sun, 8 Aug 2010 07:32:07 +0000 (UTC) (envelope-from demelier.david@gmail.com) Received: from mail-bw0-f54.google.com (mail-bw0-f54.google.com [209.85.214.54]) by mx1.freebsd.org (Postfix) with ESMTP id 430C88FC13 for ; Sun, 8 Aug 2010 07:32:06 +0000 (UTC) Received: by bwz9 with SMTP id 9so868038bwz.13 for ; Sun, 08 Aug 2010 00:32:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=pE3uoBzQYq5K+IKM20MKi02xe6yOzH7LudQZT8gQDok=; b=otJCLJ5MTPmjMEmS0GR5AlPiCSXnQltek3dQ7pjMhFv1Ek3B3P8plagU1u8mH6VBpD P/9x4zNRGDPGpMxRTVnYskkpyR1oqNt+fVLZOGUT4r0wX591DFl18CO5RHb1x3Mit9pm cKCYwr11w8UKwQsBVEP/8erj0JFKrXAVNeumQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=T1/peQaCbYnFWZzcT4AvFXBwXtKmy15wXePq0Buyolx2cEyKRcw8YQeSgOwHdWaJ7f 5uE187FyTdeDQcWTJ/2XVCV3dfIJQHgRoBvCCeGmQYY4H+DmCDQIsjClPZIPWrUBx6Ze A8lF1y+O/SOOPtO5UaeMfWGS3jv08z9ddxMbY= MIME-Version: 1.0 Received: by 10.204.82.200 with SMTP id c8mr1750970bkl.102.1281252725209; Sun, 08 Aug 2010 00:32:05 -0700 (PDT) Received: by 10.204.18.10 with HTTP; Sun, 8 Aug 2010 00:32:05 -0700 (PDT) In-Reply-To: References: Date: Sun, 8 Aug 2010 09:32:05 +0200 Message-ID: From: David DEMELIER To: Garrett Cooper Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: Freddie Cash , freebsd-ports Subject: Re: New pkg-message[.in] guideline idea X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Aug 2010 07:32:07 -0000 2010/6/24 Garrett Cooper : > On Thu, Jun 24, 2010 at 9:43 AM, David DEMELIER > wrote: >> 2010/6/24 Freddie Cash : >>> On Thu, Jun 24, 2010 at 12:04 AM, David DEMELIER >>> wrote: >>>> 2010/6/24 Janne Snabb : >>>>> On Wed, 23 Jun 2010, David DEMELIER wrote: >>>>> >>>>>> 2010/6/23 Janne Snabb : >>>>>>> >>>>>>> I find it completely useless and plainly stupid to edit the >>>>>>> pkg-messages of all ports to include lots of equal signs for tty-ba= sed >>>>>>> formatting purposes. >>>>>> >>>>>> We can take a long time to do that (we don't have to do it quickly), >>>>>> but it could be useful to standardize it for one reason : >>>>>> You will see that it's a message from the port maintainer/submitter >>>>>> and not from the program itself! Sometimes configure scripts stage s= ay >>>>>> some useless things to the user. >>>>> >>>>> You obviously did not get my point. >>>>> >>>>> I fully agree with you that displaying a line of equals signs on >>>>> tty based interfaces to make the messages stand out from other crap >>>>> when installing ports makes sense, but I STRONGLY oppose to the >>>>> idea of putting this visual formatting in the actual message files. >>>>> It is just not the right place to put it in. >>>>> >>>> I see, so maybe in the future you would like some tools that can print >>>> the message, like a GTK+ dialog, QT dialog, or an other tool, if it's >>>> your point I agree. I don't specially want a equal "=3D=3D" line, I wo= uld >>>> just something consistent, why not : nothing ? Yes we can just print >>>> the text without any visual characters, and the [future] tool will >>>> print the message as it want. >>> >>> No, what he's saying is: >>> =C2=A0- put the logic to print the separators into the appropriate bsd.= *.mk file >>> =C2=A0- remove all separators from all pkg-message* files >>> >>> That way, you can update the separators at any time by editing a >>> single file, instead of editing 20,000+ pkg-message files. =C2=A0And, t= hat >>> way, future tools can override the separator set in the mk file. >>> >>> Leave the pkg-message files as unformatted text. =C2=A0Put the formatti= ng >>> into the mk file. >>> >>> Separate content from style. >>> >> >> Yes, that was I said, sorry if you did not understand well :-) > > The only problem is that pushing all of this logic into bsd.*.mk only > solves half the problem: from source installations. It doesn't cover > binary installations via pkg_install. > > I think Doug and Phillip were on the right track with pushing the data > into a pkg_install consumable format, but the only problem is that > creating additional code that handles one more corner case for > @comment will serve to only slow down the plist parser unnecessarily. > That's why I was suggesting a scripting infrastructure, like so: > > pkgmsg() { > =C2=A0 =C2=A0local message=3D$1 > =C2=A0 =C2=A0pkgmsg_separator > =C2=A0 =C2=A0echo "$message" > =C2=A0 =C2=A0pkgmsg_separator > } > > Example: > > echo "This is an install message for my awesome new package > foo-" > +DISPLAY > pkgmsg `cat +DISPLAY` > > And considering that you almost get the functionality for free via > pkg_install (from pkg_create(8)): > > =C2=A0 =C2=A0 -D displayfile > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Display the file (by concatenat= ing it to stdout) after installing > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 the package. =C2=A0Useful for t= hings like legal notices on almost-free > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 software, etc. > > The thing about using a script function like pkgmsg too is that it can > be dynamically overwritten by certain groups in order to tailor the > messages (or mute output for customer purposes after everything has > passed QA if they use pkg_install in a product) to the meet their > needs when doing localized installations or deployments as well. > > So, why not just add the relevant bits as I described? > > Thanks, > -Garrett > I like this idea, in fact the best thing to do would be to remove any kind of decoration and just keeping the text in the pkg-message. Then we could write something like the SECURITY REPORT. So it would be something like that : =3D=3D=3D> SECURITY REPORT: This port has installed the following files which may act as network servers and may therefore pose a remote security risk to the system. /usr/local/lib/libtorrent-rasterbar.so.5 If there are vulnerabilities in these programs there may be a securit= y risk to the system. FreeBSD makes no guarantee about the security of ports included in the Ports Collection. Please type 'make deinstall' to deinstall the port if this is a concern. For more information, and contact details about the security status of this software, see the following webpage: http://www.rasterbar.com/products/libtorrent/index.html =3D=3D=3D> Message for : Text here... =3D=3D=3D> Registering installation for Then if the pkg-message is clean, only text and white line, the Mk/* infrastructure can write any kind of useless decoration, same for the GUI tools. --=20 Demelier David