From owner-freebsd-ports@FreeBSD.ORG  Tue Jun 17 19:09:46 2014
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: freebsd-ports@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 759B6E09;
 Tue, 17 Jun 2014 19:09:46 +0000 (UTC)
Received: from f10.opsec.eu (f10.opsec.eu [IPv6:2001:14f8:200:4::2])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 338082289;
 Tue, 17 Jun 2014 19:09:46 +0000 (UTC)
Received: from pi by f10.opsec.eu with local (Exim 4.82 (FreeBSD))
 (envelope-from <pi@FreeBSD.org>)
 id 1WwylI-0005So-20; Tue, 17 Jun 2014 21:09:40 +0200
Date: Tue, 17 Jun 2014 21:09:40 +0200
From: Kurt Jaeger <pi@FreeBSD.org>
To: Matthew Seaman <matthew@FreeBSD.org>
Subject: Re: ports/189880: port pgpool-II out of date.
Message-ID: <20140617190940.GI9253@f10.opsec.eu>
References: <201405170220.s4H2K0G0085365@freefall.freebsd.org>
 <538D0AAE.7090800@sorbs.net> <20140615111101.GM2341@home.opsec.eu>
 <539DA4F3.2060004@sorbs.net> <20140615142903.GQ2341@home.opsec.eu>
 <539DB9DD.3050603@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <539DB9DD.3050603@FreeBSD.org>
Cc: michelle@sorbs.net, freebsd-ports@freebsd.org
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-ports>,
 <mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports/>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
 <mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 17 Jun 2014 19:09:46 -0000

Hi!

matthew@ wrote:

> There's a number of things wrong with this port, some inherited from the
> pgpool-II port you copied, and some where you're using outmoded construct=
s.
[...]
>     - Use options helpers rather than if $(PORT_OPTIONS:MFoo).  Eg.
>       instead of
>=20
> .if ${PORT_OPTIONS:MSSL}
> USE_OPENSSL=3D    yes
> CONFIGURE_ARGS+=3D--with-openssl
> .endif
>=20
>       use:
>=20
> SSL_CONFIGURE_WITH=3D    openssl
> SSL_USE=3D               OPENSSL=3DYES
>=20
>       and similarly for the PAM option.

I tried this for PAM:

PAM_CONFIGURE_WITH+=3D            pam
PAM_USE=3D                        PAM=3Dyes

and config.log contains=20

#define USE_PAM 1

even if the PAM option is not selected.

This leads to the compile failing for pool_hba.c with some pam-related erro=
r,
see

	http://people.freebsd.org/~pi/misc/pgpool-pam-error.txt

The other method worked. Do you have any idea why that happens ?

>     - The port cannot be staged as a non-root user.  This is due to the
>       way the contrib Makefiles are written -- although elsewhere it
>       uses standard autoconf stuff, which pretty much just works for
>       staging purposes.

I'm unsure what you mean with "the contrib Makefiles" ?

You refer to the

        cd ${WRKSRC}/sql/${f} && ${GMAKE} \
                STAGEDIR=3D${STAGEDIR} \
                PREFIX=3D${PREFIX} \
                ${INSTALL_TARGET}

construct in target post-install ?

--=20
pi@FreeBSD.org         +49 171 3101372                          6 years to =
go !