From owner-freebsd-bugs  Thu Mar 12 02:00:06 1998
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Received: (from majordom@localhost)
          by hub.freebsd.org (8.8.8/8.8.8) id CAA05821
          for freebsd-bugs-outgoing; Thu, 12 Mar 1998 02:00:06 -0800 (PST)
          (envelope-from owner-freebsd-bugs@FreeBSD.ORG)
Received: (from gnats@localhost)
          by hub.freebsd.org (8.8.8/8.8.8) id CAA05812;
          Thu, 12 Mar 1998 02:00:04 -0800 (PST)
          (envelope-from gnats)
Received: from dt050ndd.san.rr.com (root@dt050ndd.san.rr.com [204.210.31.221])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id BAA05067
          for <FreeBSD-gnats-submit@freebsd.org>; Thu, 12 Mar 1998 01:53:51 -0800 (PST)
          (envelope-from dougdougdougdoug@dt050ndd.san.rr.com)
Received: (from root@localhost)
	by dt050ndd.san.rr.com (8.8.8/8.8.8) id BAA10783;
	Thu, 12 Mar 1998 01:53:50 -0800 (PST)
	(envelope-from dougdougdougdoug)
Message-Id: <199803120953.BAA10783@dt050ndd.san.rr.com>
Date: Thu, 12 Mar 1998 01:53:50 -0800 (PST)
From: Studded@dal.net
Reply-To: Studded@dal.net
To: FreeBSD-gnats-submit@FreeBSD.ORG
X-Send-Pr-Version: 3.2
Subject: kern/5990: Fix for f00f-hack warnings in -Stable (from -Current)
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org


>Number:         5990
>Category:       kern
>Synopsis:       Using f00f-hack option causes compile warnings
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:
>Keywords:
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Mar 12 02:00:01 PST 1998
>Last-Modified:
>Originator:     Doug
>Organization:
AAAG
>Release:        FreeBSD 2.2.6-BETA-0310 i386
>Environment:

	-Stable system with 586 CPU. 

>Description:

	Ever since it was introduced, the f00f hack fix in -Stable has produced
compile time warnings. This is just plain silly. Warnings like this cause unecessary
stress for inexperienced users, especially when related to bug fixes for security
problems. 

	I realize that there is some dissension as to what the "right" fix for the
f00f hack problem is, however since that issue is not likely to be resolved between
now and 2.2.6-Release, can we at least eliminate the warnings?

>How-To-Repeat:

	Compile a -Stable kernel for a 586 machine without the "no f00f hack"
option. 

>Fix:
	
	Apply the following patch. This is from -Current, the diff between 1.288 and
1.289 of /sys/i386/i386/machdep.c by Eivind. A -Stable kernel with this patch
compiles and runs with no problem

Thanks,

Doug

--- machdep.c.Dist	Fri Feb 20 02:09:12 1998
+++ machdep.c	Fri Feb 20 02:09:21 1998
@@ -1369,14 +1369,13 @@
 }
 
 #if defined(I586_CPU) && !defined(NO_F00F_HACK)
-void f00f_hack(void);
+static void f00f_hack(void *unused);
 SYSINIT(f00f_hack, SI_SUB_INTRINSIC, SI_ORDER_FIRST, f00f_hack, NULL);
 
-void
-f00f_hack(void) {
+static void
+f00f_hack(void *unused) {
 	struct region_descriptor r_idt;
-	unsigned char *tmp;
-
+        vm_offset_t tmp;
 	if (!has_f00f_bug)
 		return;
 
>Audit-Trail:
>Unformatted:

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message