From owner-cvs-all Fri Oct 5 21:19:15 2001 Delivered-To: cvs-all@freebsd.org Received: from c527597-a.cstvl1.sfba.home.com (c527597-a.cstvl1.sfba.home.com [24.176.204.87]) by hub.freebsd.org (Postfix) with ESMTP id 8968537B406; Fri, 5 Oct 2001 21:19:05 -0700 (PDT) Received: (from bmah@localhost) by c527597-a.cstvl1.sfba.home.com (8.11.6/8.11.6) id f964J5297983; Fri, 5 Oct 2001 21:19:05 -0700 (PDT) (envelope-from bmah) Message-Id: <200110060419.f964J5297983@c527597-a.cstvl1.sfba.home.com> X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.4 To: Ruslan Ermilov Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sbin/route keywords route.8 route.c In-Reply-To: <200110021004.f92A41q66142@freefall.freebsd.org> References: <200110021004.f92A41q66142@freefall.freebsd.org> Comments: In-reply-to Ruslan Ermilov message dated "Tue, 02 Oct 2001 03:04:01 -0700." From: "Bruce A. Mah" Reply-To: bmah@FreeBSD.org X-Face: g~c`.{#4q0"(V*b#g[i~rXgm*w;:nMfz%_RZLma)UgGN&=j`5vXoU^@n5v4:OO)c["!w)nD/!!~e4Sj7LiT'6*wZ83454H""lb{CC%T37O!!'S$S&D}sem7I[A 2V%N&+ X-Image-Url: http://www.employees.org/~bmah/Images/bmah-cisco-small.gif X-Url: http://www.employees.org/~bmah/ Mime-Version: 1.0 Content-Type: multipart/signed; boundary="==_Exmh_97248898P"; micalg=pgp-sha1; protocol="application/pgp-signature" Content-Transfer-Encoding: 7bit Date: Fri, 05 Oct 2001 21:19:05 -0700 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG --==_Exmh_97248898P Content-Type: text/plain; charset=us-ascii If memory serves me right, Ruslan Ermilov wrote: > ru 2001/10/02 03:04:01 PDT > > Modified files: (Branch: RELENG_4) > sbin/route keywords route.8 route.c > Log: > Mega-MFC. > > keywords: 1.5 > route.8: 1.23, 1.24, 1.25, 1.25 > route.c: 1.45, 1.46, 1.47, 1.51, 1.53 > > - Exit 1 if "add", "change", or "delete" operation fails. > > PR: bin/12489 > > - Use inet_ntoa(3) where it should have been used. This part of > code simply wasn't converted to the "new" style after the > routename() function was converted from the protocol-generic > version to protocol-specific version in CSRG revision 5.6. > > - Change the host/bits syntax introduced in route.c,v 1.24 to the > net/bits syntax, for consistency with netstat(1). > > - When changing an indirect route, kernel routing code allocates > a route to the gateway and caches it in the route structure. > It may happen (if the routing table is screwed) that the gateway > route is the same route as the one being modified, in which case > a kernel reports EDQUOT. Be more verbose about this. [snip] That's probably the best MFC commit message I've *ever* seen. Yes, it's long, but everyone can see there is absolutely no question as to what deltas were MFCed, and what effect these changes have on the code. Incidentally, this makes my job of updating release notes vastly easier...thanks! Bruce. --==_Exmh_97248898P Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.6 (FreeBSD) Comment: Exmh version 2.3.1+ 05/14/2001 iD8DBQE7voY42MoxcVugUsMRAr/eAJ99kF8nfkTokXP0Ee3sCBKrVsrUIwCeP9xj 2FcN3gdbS1kuDDtRxuZhxgk= =h1Ji -----END PGP SIGNATURE----- --==_Exmh_97248898P-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message