From owner-svn-src-user@FreeBSD.ORG Thu Nov 28 13:38:22 2013 Return-Path: Delivered-To: svn-src-user@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 8149533D; Thu, 28 Nov 2013 13:38:22 +0000 (UTC) Received: from smtp.dlink.ua (smtp.dlink.ua [193.138.187.146]) by mx1.freebsd.org (Postfix) with ESMTP id 3772B1E79; Thu, 28 Nov 2013 13:38:21 +0000 (UTC) Received: from terran (unknown [192.168.99.1]) (Authenticated sender: ray) by smtp.dlink.ua (Postfix) with ESMTPA id 2C1C6C4930; Thu, 28 Nov 2013 15:38:15 +0200 (EET) Date: Thu, 28 Nov 2013 15:38:20 +0200 From: Aleksandr Rybalko To: Andriy Gapon Subject: Re: svn commit: r257451 - in user/ed/newcons/sys/dev/drm2: . i915 radeon Message-Id: <20131128153820.f611e65cb7214f478a9ebfe5@freebsd.org> In-Reply-To: <529741CE.7040805@FreeBSD.org> References: <201310311439.r9VEd5fh025537@svn.freebsd.org> <529741CE.7040805@FreeBSD.org> X-Mailer: Sylpheed 3.2.0 (GTK+ 2.24.6; amd64-portbld-freebsd9.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Aleksandr Rybalko , src-committers@FreeBSD.org, svn-src-user@FreeBSD.org X-BeenThere: svn-src-user@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "SVN commit messages for the experimental " user" src tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Nov 2013 13:38:22 -0000 On Thu, 28 Nov 2013 15:14:54 +0200 Andriy Gapon wrote: > on 31/10/2013 16:39 Aleksandr Rybalko said the following: > > Author: ray > > Date: Thu Oct 31 14:39:04 2013 > > New Revision: 257451 > > URL: http://svnweb.freebsd.org/changeset/base/257451 > > > > Log: > > Change drm2 to attach fbd as device. > > Radeon driver not ready yet. > > > > Sponsored by: The FreeBSD Foundation > > > > Modified: > > user/ed/newcons/sys/dev/drm2/drm_fb_helper.c > > user/ed/newcons/sys/dev/drm2/i915/i915_drv.c > > user/ed/newcons/sys/dev/drm2/radeon/radeon_drv.c > > > > > Modified: user/ed/newcons/sys/dev/drm2/i915/i915_drv.c > > ============================================================================== > > --- user/ed/newcons/sys/dev/drm2/i915/i915_drv.c Thu Oct 31 14:11:14 2013 (r257450) > > +++ user/ed/newcons/sys/dev/drm2/i915/i915_drv.c Thu Oct 31 14:39:04 2013 (r257451) > > > @@ -400,6 +421,10 @@ static device_method_t i915_methods[] = > > DEVMETHOD(device_suspend, i915_suspend), > > DEVMETHOD(device_resume, i915_resume), > > DEVMETHOD(device_detach, drm_detach), > > + > > + /* Framebuffer service methods */ > > + DEVMETHOD(fb_getinfo, i915_fb_helper_getinfo), > > + > > DEVMETHOD_END > > }; > > > > > > Modified: user/ed/newcons/sys/dev/drm2/radeon/radeon_drv.c > > ============================================================================== > > --- user/ed/newcons/sys/dev/drm2/radeon/radeon_drv.c Thu Oct 31 14:11:14 2013 (r257450) > > +++ user/ed/newcons/sys/dev/drm2/radeon/radeon_drv.c Thu Oct 31 14:39:04 2013 (r257451) > > > @@ -495,6 +518,10 @@ static device_method_t radeon_methods[] > > DEVMETHOD(device_suspend, radeon_suspend), > > DEVMETHOD(device_resume, radeon_resume), > > DEVMETHOD(device_detach, drm_detach), > > + > > + /* Framebuffer service methods */ > > + DEVMETHOD(fb_getinfo, radeon_fb_helper_getinfo), > > + > > DEVMETHOD_END > > }; > > > It seems that this change these modules can not be loaded when a kernel is > compiled with syscons rather than vt (newcons). > The problem is that fb_getinfo_desc is undefined in that case. It is supposed > to come from fb_if.m -> fb_if.c -> fb_if.o. > > Is this intentional? Yeah, currently fbd is not standalone module, it is depended on VT(9) (a.k.a. newcons) presence. From another point, syscons can't use (at least now) DRM's fb_helper. If syscons present, newcons will not be able to attach, since he will need to replace handler of /dev/ttyvX files, which is impossible as I know (at least now). > > -- > Andriy Gapon -- Aleksandr Rybalko