From owner-cvs-all Thu May 30 10:18:59 2002 Delivered-To: cvs-all@freebsd.org Received: from kayak.xcllnt.net (209-128-86-226.bayarea.net [209.128.86.226]) by hub.freebsd.org (Postfix) with ESMTP id 37BF737B400; Thu, 30 May 2002 10:18:45 -0700 (PDT) Received: from dhcp01.pn.xcllnt.net (dhcp01.pn.xcllnt.net [192.168.4.201]) by kayak.xcllnt.net (8.11.6/8.11.4) with ESMTP id g4UHIZJ68374; Thu, 30 May 2002 10:18:35 -0700 (PDT) (envelope-from marcel@kayak.pn.xcllnt.net) Received: from dhcp01.pn.xcllnt.net (localhost [127.0.0.1]) by dhcp01.pn.xcllnt.net (8.12.3/8.12.3) with ESMTP id g4UHIcST000463; Thu, 30 May 2002 10:18:38 -0700 (PDT) (envelope-from marcel@dhcp01.pn.xcllnt.net) Received: (from marcel@localhost) by dhcp01.pn.xcllnt.net (8.12.3/8.12.3/Submit) id g4UHIcgZ000462; Thu, 30 May 2002 10:18:38 -0700 (PDT) (envelope-from marcel) Date: Thu, 30 May 2002 10:18:38 -0700 From: Marcel Moolenaar To: Tony Finch Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/sys gpt.h Message-ID: <20020530171838.GB308@dhcp01.pn.xcllnt.net> References: <200205300544.g4U5iN586002@freefall.freebsd.org> <20020530094039.B10098@chiark.greenend.org.uk> <20020530103803.D10098@chiark.greenend.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20020530103803.D10098@chiark.greenend.org.uk> User-Agent: Mutt/1.3.99i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Thu, May 30, 2002 at 10:38:03AM +0100, Tony Finch wrote: > > Actually, since you wouldn't have committed this without it getting the > results you expected, I've done some more research and it looks like > this is a C99 feature that gcc mis-implements, so you are depending on > a gcc bug. Sigh. Ok, I'll rip it out and add an explicit field of type uint32_t to make the struct a multiple of 8 bytes. I'll change the CTASSERT in geom_gpt.c to test for size 96 and I'll simply subtract the size of the padding field from the value returned by sizeof() to get the actual size I need to write into the header in the tool that creates the GPT (not in the source tree). I think I was just avoiding to have to do the latter. Thanks for checking, -- Marcel Moolenaar USPA: A-39004 marcel@xcllnt.net To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message