From owner-freebsd-hackers Sat Sep 13 23:52:53 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.7/8.8.7) id XAA25835 for hackers-outgoing; Sat, 13 Sep 1997 23:52:53 -0700 (PDT) Received: from zibbi.mikom.csir.co.za (zibbi.mikom.csir.co.za [146.64.24.58]) by hub.freebsd.org (8.8.7/8.8.7) with ESMTP id XAA25830 for ; Sat, 13 Sep 1997 23:52:46 -0700 (PDT) Received: (from jhay@localhost) by zibbi.mikom.csir.co.za (8.8.7/8.8.7) id IAA07487; Sun, 14 Sep 1997 08:52:21 +0200 (SAT) From: John Hay Message-Id: <199709140652.IAA07487@zibbi.mikom.csir.co.za> Subject: Re: rc & rc.conf In-Reply-To: <199709140609.PAA00821@word.smith.net.au> from Mike Smith at "Sep 14, 97 03:39:51 pm" To: mike@smith.net.au (Mike Smith) Date: Sun, 14 Sep 1997 08:52:21 +0200 (SAT) Cc: freebsd-hackers@FreeBSD.ORG X-Mailer: ELM [version 2.4ME+ PL31 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-freebsd-hackers@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk > > > > Yes, I'm not quite *that* stupid. We have two variables here: a > > -flags which is set with the flags, and an -enable which is set to > > either YES or NO. The original logic says "don't do it unless -enable > > is YES". Brian's saying "do it unless -enable is NO". I don't see an > > advantage in doing it this way, and I certainly don't see a disaster > > waiting to happen in the old way. > > The advantages are combined; consistency with all of the other similar > options, and by using "not NO", the _enable and _flags variables may > subsequently be combined. > Hmmm. I'm not sure about the consistency. A "grep NO rc" leaves me with 3 variables that is checked against NO and "grep YES rc" leaves me with 9 variables checked against YES, although if you change this it will be 5 NO's against 7 YES's. BTW. The way I keep rc and rc.conf in sync is to make all my changes in rc.conf.local, so I can always just copy rc and rc.conf into /etc without worry that I'll clobber some of my local setup. John -- John Hay -- John.Hay@mikom.csir.co.za