From owner-freebsd-ports-bugs Fri Jan 24 4:51: 3 2003 Delivered-To: freebsd-ports-bugs@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 264BA37B401 for ; Fri, 24 Jan 2003 04:51:01 -0800 (PST) Received: from wrzx35.rz.uni-wuerzburg.de (wrzx35.rz.uni-wuerzburg.de [132.187.3.35]) by mx1.FreeBSD.org (Postfix) with ESMTP id 37F6043F1E for ; Fri, 24 Jan 2003 04:50:59 -0800 (PST) (envelope-from q@uni.de) Received: from wrzx34.rz.uni-wuerzburg.de (wrzx34.rz.uni-wuerzburg.de [132.187.3.34]) by wrzx35.rz.uni-wuerzburg.de (8.8.8/8.8.8/uniwue-MM-1.05) with ESMTP id NAA194806 for ; Fri, 24 Jan 2003 13:50:58 +0100 (CET) Received: from virusscan (localhost [127.0.0.1]) by wrzx34.rz.uni-wuerzburg.de (Postfix) with ESMTP id C5C64487B4 for ; Fri, 24 Jan 2003 13:50:57 +0100 (CET) Received: from wrzx37.rz.uni-wuerzburg.de (wrzx37.rz.uni-wuerzburg.de [132.187.3.37]) by wrzx34.rz.uni-wuerzburg.de (Postfix) with ESMTP id AF80C13F0 for ; Fri, 24 Jan 2003 13:50:57 +0100 (CET) Received: from spamchecker (localhost [127.0.0.1]) by wrzx37.rz.uni-wuerzburg.de (Postfix) with ESMTP id E8495AA5E for ; Fri, 24 Jan 2003 13:50:56 +0100 (CET) Received: from frodo.galgenberg.net (galgenberg.net [132.187.222.250]) by wrzx37.rz.uni-wuerzburg.de (Postfix) with SMTP id D7473AA52 for ; Fri, 24 Jan 2003 13:50:56 +0100 (CET) Received: (qmail 77516 invoked from network); 24 Jan 2003 12:50:56 -0000 Received: from gb-007.galgenberg.net (HELO roadrunner) (@132.187.222.7) by galgenberg.net with SMTP; 24 Jan 2003 12:50:56 -0000 Date: Fri, 24 Jan 2003 13:50:54 +0100 From: Ulrich Spoerlein To: "Simon 'corecode' Schubert" Cc: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/47406: [Patch] Remove {PERL} from ports@'s ports Message-Id: <20030124135054.76dbb045.q@uni.de> In-Reply-To: <200301232330.h0NNU7EI005549@freefall.freebsd.org> References: <200301232330.h0NNU7EI005549@freefall.freebsd.org> X-Mailer: Sylpheed version 0.8.8claws (GTK+ 1.2.10; i386-portbld-freebsd4.7) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, hits=-0.7 required=8.0 tests=CARRIAGE_RETURNS,IN_REP_TO,NICE_HELO,QUOTED_EMAIL_TEXT, REFERENCES,SPAM_PHRASE_00_01,UPPERCASE_25_50 version=2.42-string_20021002 X-Spam-Level: X-Virus-Scanned: by amavisd-new (Rechenzentrum Universitaet Wuerzburg) Sender: owner-freebsd-ports-bugs@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org On 2003/01/23-15:30:07 Simon 'corecode' Schubert wrote: > > diff -urN /usr/ports/x11/xcolorsel/Makefile xcolorsel/Makefile > [...] > > -WRKSRC= $(WRKDIR)/xcolorsel > > +WRKSRC= ${WRKDIR}/xcolorsel > > woot? () -> {} Makes portlint happy. > [...] > > + @${REINPLACE_CMD} -e 's|app2head|./app2head|g' \ > > + -e 's|XawClientLibs|-lXaw3d \$$\(XMULIBONLY\) \$$\(XTOOLLIB\) > > \$$\(XPMLIB) \$$\(XLIB\)|g' ${WRKSRC}/Imakefile > > you don't need to escape parentheses and $ in this context: > -e 's|XawClientLibs|-lXaw3d $$(XMULIBONLY) $$(XTOOLLIB) $$(XPMLIB) > $$(XLIB)|g' ${WRKSRC}/Imakefile Sorry, just after sending this PR I read another post (from you?) about sed's regex format, the -E switch and stuff. It's just that I "learned" regex with Perl, so my Understanding of regexes is very perl-specific :( > > diff -urN /usr/ports/deskutils/gnofin/Makefile gnofin/Makefile > [...] > > + ${REINPLACE_CMD} -E -e 's|-lpthread|${PTHREAD_LIBS}|g' \ > > + -e 's|DATADIRNAME=lib|DATADIRNAME=share|g' \ > > + -e 's|USE_INCLUDED_LIBINTL=yes|#USE_INCLUDED_LIBINTL=yes|g' \ > > + -e 's|\$$\(top_builddir\)/intl/libintl.a|-lintl|g' > > ${WRKSRC}/configure > > what for -E ? > either this way or without -E and without escaping the parentheses > (looks better to me) Yes of course, see explanation above. > > diff -urN /usr/ports/security/fwbuilder/Makefile fwbuilder/Makefile > [...] > > + @${REINPLACE_CMD} -e 's/lc_r/pthread/' ${WRKSRC}/configure ;\ > > use ${PTHREAD_LIBS}? *sigh*... > [...] > > + @${REINPLACE_CMD} -e 's|^CFLAGS\s+=\s+-Wall\s+-g|CFLAGS = \@CFLAGS@ > > -Wall|' ${WRKSRC}/src/$i > > did you test this? sed doesn't know \s, just [[:space:]] > you don't need to escape @ in sed I hope sed understands [[:space:]]+ ? To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports-bugs" in the body of the message