From owner-freebsd-x11@FreeBSD.ORG Tue Dec 25 03:20:01 2012 Return-Path: Delivered-To: freebsd-x11@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 6059438C for ; Tue, 25 Dec 2012 03:20:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 451DA8FC12 for ; Tue, 25 Dec 2012 03:20:01 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id qBP3K0Pt041758 for ; Tue, 25 Dec 2012 03:20:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id qBP3K0s4041757; Tue, 25 Dec 2012 03:20:00 GMT (envelope-from gnats) Date: Tue, 25 Dec 2012 03:20:00 GMT Message-Id: <201212250320.qBP3K0s4041757@freefall.freebsd.org> To: freebsd-x11@FreeBSD.org Cc: From: Jan Beich Subject: Re: ports/174524: [PATCH] devel/gccmakedep X-BeenThere: freebsd-x11@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: Jan Beich List-Id: X11 on FreeBSD -- maintaining and support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Dec 2012 03:20:01 -0000 The following reply was made to PR ports/174524; it has been noted by GNATS. From: Jan Beich To: Nikolai Lifanov Cc: bug-followup@FreeBSD.org Subject: Re: ports/174524: [PATCH] devel/gccmakedep Date: Tue, 25 Dec 2012 13:12:13 +1000 Nikolai Lifanov writes: > This has been resolved in some other x11/ ports, notably libX11, xdm, > etc. by removing this check post patch. > > @${REINPLACE_CMD} 's/test.*-traditional.*;/true;/' ... clang-cpp should be safe with x11/xdm/files/patch-config-Makefile.in. - only one .cpp file i.e., gccmdep.cpp (the program itself) - syntax breakage is minimal (ucpp is no better) [1] - doesn't invoke "cpp" during runtime (unlike imake) [1] here're a few examples #! line must be first, see execve(2) --- gccmdep.cpp47 +++ gccmdep.clang-cpp @@ -1,3 +1,5 @@ + + #!/bin/sh # whitespace around `=' is not allowed by sh(1) --- gccmdep.cpp47 +++ gccmdep.ucpp @@ -7,10 +8,10 @@ # Based on mdepend.cpp and code supplied by Hongjiu Lu # TMP=mdep$$.tmp -CC=cc -RM="rm -f" -LN=ln -MV=mv +CC= cc +RM= "rm -f" +LN= ln +MV= mv ${RM} ${TMP} trap "${RM} ${TMP}*; exit 1" 1 2 15 trap "${RM} ${TMP}*; exit 0" 1 2 13