From owner-cvs-all@FreeBSD.ORG Thu Aug 24 21:20:48 2006 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D625916A4E1; Thu, 24 Aug 2006 21:20:48 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id 19EF943D6D; Thu, 24 Aug 2006 21:20:45 +0000 (GMT) (envelope-from scottl@samsco.org) Received: from [10.10.3.185] ([165.236.175.187]) (authenticated bits=0) by pooker.samsco.org (8.13.4/8.13.4) with ESMTP id k7OLKb7I019354; Thu, 24 Aug 2006 15:20:42 -0600 (MDT) (envelope-from scottl@samsco.org) Message-ID: <44EE1820.9050709@samsco.org> Date: Thu, 24 Aug 2006 15:20:32 -0600 From: Scott Long User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.12) Gecko/20060206 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Guido van Rooij References: <200608240737.k7O7bDMC085424@repoman.freebsd.org> <20060824101606.414e8bf6@kan.dnsalias.net> <44EDCDD4.6070709@samsco.org> <200608241522.43325.jhb@freebsd.org> <20060824210333.GB59856@gvr.gvr.org> In-Reply-To: <20060824210333.GB59856@gvr.gvr.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=1.5 required=3.8 tests=SPF_SOFTFAIL autolearn=no version=3.1.1 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.1.1 (2006-03-10) on pooker.samsco.org Cc: cvs-src@freebsd.org, cvs-all@freebsd.org, src-committers@freebsd.org, Alexander Kabaev , John Baldwin Subject: Re: cvs commit: src/contrib/ipfilter HISTORY Makefile bpf_filter.c ip_fil.c ipf.h ipmon.h ipt.h kmem.h mlfk_rule.c opts.h radix.c radix_ipf.h snoop.h src/contrib/ipfilter/BSD Makefile Makefile.ipsend kupgrade src/contrib/ipfilter/iplang iplang_l.l ... X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Aug 2006 21:20:48 -0000 Guido van Rooij wrote: > On Thu, Aug 24, 2006 at 03:22:42PM -0400, John Baldwin wrote: > >>>>>>> Log: >>>>>>> MFC: ipfilter 4.1.13 >>>>>> >>>>>>This begs for a question: if ipfilter can not be updated without >>>>>>breaking the tree anymore, does it belong there in the first place? >>>>> >>>>>We could of course also get rid of the tree ;) >>>>> >>>>>-Guido >>>> >>>>Tree without ipfilter or ipfilter without tree - this is a >>>>technicality. >>>> >>>>Seriously though, I wonder how ipfilter is being tested before being >>>>checked in? Past two commits by you suggested that no testing was done >>>>at all. >>>> >>> >>>Missing an added file when doing a check-in is a forgivable mistake, >>>especially since Guido isn't the author and likely doesn't have as deep >>>of an understanding of the changes as the author does. And, I do highly >>>appreciate that Guido is responding quickly to the problems. The >>>process with ipfilter still isn't perfect, but it's definitely an >>>improvement over the past. >> >>Yes, this is the first import Guido has done, and I think it has gone well >>relatively speaking. Overall I think ipfilter imports will become less >>eventful in the future than they have been in the past. > > > Thanks (also to Scott). It wasn't my first though :-( > > To all others: it was just a stupid mistake and I already apologized. > > -Guido The key is to start with low expectations. Now that you've made the mistake of doing a good job, expectations will raise accordingly =-) Scott