From owner-svn-src-all@freebsd.org Fri Apr 8 16:16:23 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 89C1AB08A3F; Fri, 8 Apr 2016 16:16:23 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 6B8ED16A8; Fri, 8 Apr 2016 16:16:23 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from ralph.baldwin.cx (c-73-231-226-104.hsd1.ca.comcast.net [73.231.226.104]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 6AF0AB946; Fri, 8 Apr 2016 12:16:22 -0400 (EDT) From: John Baldwin To: Stanislav Galabov Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r297717 - head/sys/mips/mediatek Date: Fri, 08 Apr 2016 09:11:15 -0700 Message-ID: <2014592.cEATiW0yl7@ralph.baldwin.cx> User-Agent: KMail/4.14.3 (FreeBSD/10.2-STABLE; KDE/4.14.3; amd64; ; ) In-Reply-To: <201604081526.u38FQnvC062652@repo.freebsd.org> References: <201604081526.u38FQnvC062652@repo.freebsd.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Fri, 08 Apr 2016 12:16:22 -0400 (EDT) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Apr 2016 16:16:23 -0000 On Friday, April 08, 2016 03:26:49 PM Stanislav Galabov wrote: > Author: sgalabov > Date: Fri Apr 8 15:26:49 2016 > New Revision: 297717 > URL: https://svnweb.freebsd.org/changeset/base/297717 > > Log: > Introduce Mediatek/Ralink PCIe support > > This revision introduces PCIe support for the relevant Mediatek/Ralink > SoCs. > Currently the PCIe support is not converted to INTRNG, this may be a > task for the future. > > Approved by: adrian (mentor) > Sponsored by: Smartcom - Bulgaria AD > Differential Revision: https://reviews.freebsd.org/D5886 I would _really_ like to get away from having N different Foo-PCI bridge drivers that all do an initial walk of the PCI hierarchy configuring BARs and PCI-PCI bridge I/O windows. With NEW_PCIB, the PCI-PCI bridge driver is capable of figuring out windows on its own, and the PCI bus is also capable of allocating resource for BARs. Leveraging that means removing N copies of this approach and having one place to manage BARs, etc. Can you please try removing all of your I/O window and BAR setup and seeing if the PCI bus works ok? If not, we should fix it so that it does, but fixing the PCI bus means we only have to fix one place, not N. (And yes, I want to axe the code from the various arm places that do this as well and want to avoid adding even more copies of it.) -- John Baldwin