From owner-freebsd-ports-bugs@FreeBSD.ORG Thu Jul 4 10:30:01 2013 Return-Path: Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 7D21C3A1 for ; Thu, 4 Jul 2013 10:30:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 566E91D5C for ; Thu, 4 Jul 2013 10:30:01 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id r64AU1Vb024889 for ; Thu, 4 Jul 2013 10:30:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.7/8.14.7/Submit) id r64AU1MZ024888; Thu, 4 Jul 2013 10:30:01 GMT (envelope-from gnats) Date: Thu, 4 Jul 2013 10:30:01 GMT Message-Id: <201307041030.r64AU1MZ024888@freefall.freebsd.org> To: freebsd-ports-bugs@FreeBSD.org Cc: From: Andrea Venturoli Subject: Re: ports/180168: [maintainer update] net/Sockets 2.3.9.9 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: Andrea Venturoli List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Jul 2013 10:30:01 -0000 The following reply was made to PR ports/180168; it has been noted by GNATS. From: Andrea Venturoli To: Raphael Kubo da Costa Cc: bug-followup@FreeBSD.org Subject: Re: ports/180168: [maintainer update] net/Sockets 2.3.9.9 Date: Thu, 04 Jul 2013 12:21:37 +0200 On 07/04/13 11:47, Raphael Kubo da Costa wrote: > Thank you. I've got a few additional comments after looking at the > port's Makefile: Thanks to you and please forgive my inexperience. > o Instead of the BUILD_DEPENDS line you added, you can use > USE_GNOME=libxml2:build instead. Fine for me; I didn't know about this. Do you want me to send another patch? > o libxml2 does not seem to be a build-dependency, but rather a generic > library dependency (ie. LIB_DEPENDS). The pkg-config files generated > by the port depend on it, for example. Hmm... I checked the port's own Makefile and it does not link against it. Also, I'm developing a project which uses this library and I don't link against libxml2 either. However, feel free to put it as a library dependency if you think it should be like this. Or I can send another patch if you confirm. > o There's a section in the Makefile that says > > #Not needed without execinfo or xml > #CFLAGS+= -I${LOCALBASE}/include > #LDFLAGS+= -L${LOCALBASE}/lib > > Now that xml support has been added, do you need to uncomment out > those lines? I don't think so... this might be remnants of a very old version. libxml2 requires "-I${LOCALBASE}/include/libxml2 -I${LOCALBASE}/include", but that is achieved by uncommenting the following line in the port's Makefile: CFLAGS += `xml2-config --cflags` This is done through "patch/files-Makefile". If changing CFLAGS in our Makefile is considered to be more elegant, the above lines must still be altered (patch/files-Makfile won't go away, though). I tested against 8.3 and 9.1 and it compiles fine. Did you find some problem on another platform? bye & Thanks av.