From owner-cvs-src@FreeBSD.ORG  Tue Aug 23 03:44:07 2005
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@FreeBSD.org
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 426B616A41F;
	Tue, 23 Aug 2005 03:44:07 +0000 (GMT)
	(envelope-from truckman@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 145AC43D48;
	Tue, 23 Aug 2005 03:44:07 +0000 (GMT)
	(envelope-from truckman@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j7N3i6Um093969;
	Tue, 23 Aug 2005 03:44:06 GMT
	(envelope-from truckman@repoman.freebsd.org)
Received: (from truckman@localhost)
	by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j7N3i6EF093968;
	Tue, 23 Aug 2005 03:44:06 GMT (envelope-from truckman)
Message-Id: <200508230344.j7N3i6EF093968@repoman.freebsd.org>
From: Don Lewis <truckman@FreeBSD.org>
Date: Tue, 23 Aug 2005 03:44:06 +0000 (UTC)
To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org
X-FreeBSD-CVS-Branch: HEAD
Cc: 
Subject: cvs commit: src/sys/kern vfs_subr.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 23 Aug 2005 03:44:07 -0000

truckman    2005-08-23 03:44:06 UTC

  FreeBSD src repository

  Modified files:
    sys/kern             vfs_subr.c 
  Log:
  Back out the removal of LK_NOWAIT from the VOP_LOCK() call in
  vlrureclaim() in vfs_subr.c 1.636  because waiting for the vnode
  lock aggravates an existing race condition.  It is also undesirable
  according to the commit log for 1.631.
  
  Fix the tiny race condition that remains by rechecking the vnode
  state after grabbing the vnode lock and grabbing the vnode interlock.
  
  Fix the problem of other threads being starved (which 1.636 attempted
  to fix by removing LK_NOWAIT) by calling uio_yield() periodically
  in vlrureclaim().  This should be more deterministic than hoping
  that VOP_LOCK() without LK_NOWAIT will block, which may not happen
  in this loop.
  
  Reviewed by:    kan
  MFC after:      5 days
  
  Revision  Changes    Path
  1.642     +37 -7     src/sys/kern/vfs_subr.c