From owner-cvs-all  Sun Mar 11 14:24:35 2001
Delivered-To: cvs-all@freebsd.org
Received: from obsecurity.dyndns.org (adsl-63-207-60-158.dsl.lsan03.pacbell.net [63.207.60.158])
	by hub.freebsd.org (Postfix) with ESMTP
	id 7112437B718; Sun, 11 Mar 2001 14:24:28 -0800 (PST)
	(envelope-from kris@obsecurity.org)
Received: by obsecurity.dyndns.org (Postfix, from userid 1000)
	id CD3E866F14; Sun, 11 Mar 2001 14:24:25 -0800 (PST)
Date: Sun, 11 Mar 2001 14:24:25 -0800
From: Kris Kennaway <kris@obsecurity.org>
To: Robert Watson <rwatson@FreeBSD.org>
Cc: Mark Murray <mark@grondar.za>, Akinori MUSHA <knu@iDaemons.org>,
	cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/secure/lib/libcrypt blowfish.c blowfish.h crypt-blowfish.c src/lib/libcrypt Makefile crypt.3 crypt.c crypt.h
Message-ID: <20010311142425.C65721@mollari.cthul.hu>
References: <200103111643.f2BGhCf84561@gratis.grondar.za> <Pine.NEB.3.96L.1010311133847.23168S-100000@fledge.watson.org>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-md5;
	protocol="application/pgp-signature"; boundary="32u276st3Jlj2kUU"
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
In-Reply-To: <Pine.NEB.3.96L.1010311133847.23168S-100000@fledge.watson.org>; from rwatson@FreeBSD.org on Sun, Mar 11, 2001 at 01:40:09PM -0500
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG


--32u276st3Jlj2kUU
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Mar 11, 2001 at 01:40:09PM -0500, Robert Watson wrote:
> On Sun, 11 Mar 2001, Mark Murray wrote:
>=20
> > > Neat!  Now we too can design and sell some blowfish T-shirts? ;)
> > > Anyway, this is another great fruit from OpenBSD!
> >=20
> > :-)
> >=20
> > > By the way, I found a possible typo:
> >=20
> > Nope. This covers "sub-classes" as well.
> >=20
> > $2$ and $2a$ are blowfish. Go figure :-(
>=20
> However, it would still be better to have two explicit checks than a
> single prefix, because there's nothing to prevent $2b$ from being another
> variant, only an incompatible one.  I.e., I would feel uncomfortable
> matching only $2, and instead would rather see two checks, one for $2$ and
> one for $2a$.

It looks like the code already does this.

Kris

--32u276st3Jlj2kUU
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.4 (FreeBSD)
Comment: For info see http://www.gnupg.org

iD8DBQE6q/sYWry0BWjoQKURAgKOAKC0/zi+dHiTEx+ivHqKrpHlmNcGmwCggeZw
R9dFpM2dZ1y5MO9+fKkvJQo=
=GAtX
-----END PGP SIGNATURE-----

--32u276st3Jlj2kUU--

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message