From owner-svn-src-all@FreeBSD.ORG Tue Jan 20 21:11:43 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 6993036B; Tue, 20 Jan 2015 21:11:43 +0000 (UTC) Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "cell.glebius.int.ru", Issuer "cell.glebius.int.ru" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 58534C8D; Tue, 20 Jan 2015 21:11:40 +0000 (UTC) Received: from cell.glebius.int.ru (localhost [127.0.0.1]) by cell.glebius.int.ru (8.14.9/8.14.9) with ESMTP id t0KLBbEx074355 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Wed, 21 Jan 2015 00:11:37 +0300 (MSK) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebius.int.ru (8.14.9/8.14.9/Submit) id t0KLBb9F074354; Wed, 21 Jan 2015 00:11:37 +0300 (MSK) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Wed, 21 Jan 2015 00:11:37 +0300 From: Gleb Smirnoff To: Konstantin Belousov Subject: Re: svn commit: r277213 - in head: share/man/man9 sys/kern sys/ofed/include/linux sys/sys Message-ID: <20150120211137.GY15484@FreeBSD.org> References: <201501151532.t0FFWV2Y037455@svn.freebsd.org> <54BDD9E1.6090505@selasky.org> <20150120075126.GA42409@kib.kiev.ua> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150120075126.GA42409@kib.kiev.ua> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: Hans Petter Selasky , "svn-src-head@freebsd.org" , Adrian Chadd , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Jan 2015 21:11:43 -0000 On Tue, Jan 20, 2015 at 09:51:26AM +0200, Konstantin Belousov wrote: K> > Like stated in the manual page, callout_reset_curcpu/on() does not work K> > with MPSAFE callouts any more! K> I.e. you 'fixed' some undeterminate bugs in callout migration by not K> doing migration at all anymore. K> K> > K> > You need to use callout_init_{mtx,rm,rw} and remove the custom locking K> > inside the callback in the TCP stack to get it working like before! K> K> No, you need to do this, if you think that whole callout KPI must be K> rototiled. It is up to the person who modifies the KPI, to ensure that K> existing code is not broken. K> K> As I understand, currently we are back to the one-cpu callouts. K> Do other people consider this situation acceptable ? I think this isn't acceptable. The commit to a complex subsystem lacked a review from persons involved in the system before. The commit to subsystem broke consumers of the subsystem and this was even done not accidentially, but due to Hans not caring about it. As for me this is enough to request a backout, and let the change back in only after proper review. -- Totus tuus, Glebius.