From owner-freebsd-current@FreeBSD.ORG Sat Apr 14 14:04:20 2007 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id C366716A402; Sat, 14 Apr 2007 14:04:20 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (arm132.internetdsl.tpnet.pl [83.17.198.132]) by mx1.freebsd.org (Postfix) with ESMTP id 5DA4113C46A; Sat, 14 Apr 2007 14:04:20 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id 188D6487F2; Sat, 14 Apr 2007 16:04:19 +0200 (CEST) Received: from localhost (154.81.datacomsa.pl [195.34.81.154]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id 0026745B26; Sat, 14 Apr 2007 16:04:13 +0200 (CEST) Date: Sat, 14 Apr 2007 16:03:58 +0200 From: Pawel Jakub Dawidek To: Hidetoshi Shimokawa Message-ID: <20070414140358.GG10527@garage.freebsd.pl> References: <86slb3t74o.wl%simokawa@FreeBSD.ORG> <20070414134653.GF10527@garage.freebsd.pl> <626eb4530704140701n3b06df02o58f288baad4cf3d1@mail.gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="w2JjAQZceEVGylhD" Content-Disposition: inline In-Reply-To: <626eb4530704140701n3b06df02o58f288baad4cf3d1@mail.gmail.com> X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 7.0-CURRENT i386 User-Agent: mutt-ng/devel-r804 (FreeBSD) X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=BAYES_00 autolearn=ham version=3.0.4 Cc: freebsd-current@freebsd.org Subject: Re: zdb patch X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Apr 2007 14:04:20 -0000 --w2JjAQZceEVGylhD Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Apr 14, 2007 at 11:01:35PM +0900, Hidetoshi Shimokawa wrote: > On 4/14/07, Pawel Jakub Dawidek wrote: > >On Sat, Apr 14, 2007 at 10:31:19PM +0900, Hidetoshi Shimokawa wrote: > >> Here is a patch for zdb. > >> Now we can 'zdb -u pool' :-) > >> > >> =3D=3D=3D=3D //depot/user/simokawa/firewire/contrib/opensolaris/lib/li= bzpool/common/kernel.c#2 - /home/p4/firewire/contrib/opensolaris/lib/libzpo= ol/common/kernel.c =3D=3D=3D=3D > >> @@ -38,6 +38,7 @@ > >> #include > >> #include > >> #include > >> +#include > >> > >> /* > >> * Emulation of kernel services in userland. > >> @@ -291,7 +292,11 @@ > >> > >> ASSERT(abstime > 0); > >> top: > >> +#if 0 > >> delta =3D abstime - lbolt; > >> +#else /* for compatibility with FreeBSD kernel */ > >> + delta =3D abstime; > >> +#endif > > > >What is this change for? It works ok without it here. >=20 > It is necessary for userland because of your change 104486. > (see p4 describe 104486) >=20 > Without above patch, cv_timedwait() never sleeps and arc_reclaim_thread > never releases the lock. Right... How can I reproduce the problem, because ztest seems to work just fine? BTW. Please commit this change as well, but just remove ' - lbolt' and forget about this '#if 0'. --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --w2JjAQZceEVGylhD Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (FreeBSD) iD8DBQFGIN9OForvXbEpPzQRAqBmAJ4wpBXPninR+TNkv9kAdtjN309s9QCg857b oYzfkK5HxmzL1nt+prG9zqA= =nCPz -----END PGP SIGNATURE----- --w2JjAQZceEVGylhD--