From owner-freebsd-ports-bugs@FreeBSD.ORG Fri Sep 6 18:50:01 2013 Return-Path: Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 2D265789 for ; Fri, 6 Sep 2013 18:50:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 0B291268C for ; Fri, 6 Sep 2013 18:50:01 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id r86Io0KT064241 for ; Fri, 6 Sep 2013 18:50:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.7/8.14.7/Submit) id r86Io0AK064240; Fri, 6 Sep 2013 18:50:00 GMT (envelope-from gnats) Resent-Date: Fri, 6 Sep 2013 18:50:00 GMT Resent-Message-Id: <201309061850.r86Io0AK064240@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Ben Morrow Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 1A725758 for ; Fri, 6 Sep 2013 18:47:56 +0000 (UTC) (envelope-from mauzo@morrow.me.uk) Received: from isis.morrow.me.uk (isis.morrow.me.uk [204.109.63.142]) by mx1.freebsd.org (Postfix) with ESMTP id EC0892673 for ; Fri, 6 Sep 2013 18:47:55 +0000 (UTC) Received: from anubis.morrow.me.uk (host86-182-11-25.range86-182.btcentralplus.com [86.182.11.25]) (Authenticated sender: mauzo) by isis.morrow.me.uk (Postfix) with ESMTPSA id 169CB450B9 for ; Fri, 6 Sep 2013 18:47:48 +0000 (UTC) Received: by anubis.morrow.me.uk (Postfix, from userid 5001) id 03F08D6D6; Fri, 6 Sep 2013 19:47:46 +0100 (BST) Message-Id: <20130906184747.03F08D6D6@anubis.morrow.me.uk> Date: Fri, 6 Sep 2013 19:47:46 +0100 (BST) From: Ben Morrow To: FreeBSD-gnats-submit@freebsd.org X-Send-Pr-Version: 3.113 Subject: ports/181896: editors/vim: gvim requires pkgconf to build X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: Ben Morrow List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Sep 2013 18:50:01 -0000 >Number: 181896 >Category: ports >Synopsis: editors/vim: gvim requires pkgconf to build >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Fri Sep 06 18:50:00 UTC 2013 >Closed-Date: >Last-Modified: >Originator: Ben Morrow >Release: FreeBSD 9.1-RELEASE-p4 amd64 >Organization: >Environment: System: FreeBSD anubis.morrow.me.uk 9.1-RELEASE-p4 FreeBSD 9.1-RELEASE-p4 #1 r+47614d7: Tue Jun 25 08:08:41 BST 2013 mauzo@anubis:/usr/obj/usr/src/sys/ANUBIS amd64 >Description: I'm not sure what has caused the recent spate of ports needing explicit pkgconf dependencies, but gvim appears to have been missed. Without pkgconf installed configure fails to find the GTK libraries, and vim builds without a GUI. >How-To-Repeat: Build editors/vim with the GTK GUI selected, but without pkgconf installed (say, as part of a 'poudriere bulk' build). configure will fail to find the installed GTK libraries, and the GUI will not be built. >Fix: Patch included below. This also removes the --with-gtk-prefix option, since configure was complaining about it. I am assuming that the Gnome GUI needs pkgconf, just as the GTK one does. diff --git a/editors/vim/Makefile b/editors/vim/Makefile index bc6ccea..b68f158 100644 --- a/editors/vim/Makefile +++ b/editors/vim/Makefile @@ -146,13 +146,15 @@ USE_XORG+= xaw . endif . if ${PORT_OPTIONS:MGTK2} +USES+= pkgconfig USE_GNOME= gtk20 -CONF_OPT_GUI="--enable-gui=gtk2 --with-gtk-prefix=${LOCALBASE}" +CONF_OPT_GUI="--enable-gui=gtk2" MAKE_ARGS+= X_LIBS="$(X_LIBS) -lXt" USE_XORG+= xt . endif . if ${PORT_OPTIONS:MGNOME} +USES+= pkgconfig USE_GNOME= libgnomeui PKGNAMESUFFIX= -gnome2 CONF_OPT_GUI="--enable-gui=gnome2" >Release-Note: >Audit-Trail: >Unformatted: