From owner-cvs-ports@FreeBSD.ORG Sun Dec 31 17:04:37 2006 Return-Path: X-Original-To: cvs-ports@FreeBSD.org Delivered-To: cvs-ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 6B03016A417 for ; Sun, 31 Dec 2006 17:04:37 +0000 (UTC) (envelope-from alepulver@FreeBSD.org) Received: from relay03.pair.com (relay03.pair.com [209.68.5.17]) by mx1.freebsd.org (Postfix) with SMTP id 1BD7A13C455 for ; Sun, 31 Dec 2006 17:04:37 +0000 (UTC) (envelope-from alepulver@FreeBSD.org) Received: (qmail 87569 invoked by uid 0); 31 Dec 2006 16:37:56 -0000 Received: from unknown (HELO phobos.mars.bsd) (unknown) by unknown with SMTP; 31 Dec 2006 16:37:56 -0000 X-pair-Authenticated: 200.115.252.195 Date: Sun, 31 Dec 2006 13:37:53 -0300 From: Alejandro Pulver To: pav@FreeBSD.org Message-ID: <20061231133753.4156b868@phobos.mars.bsd> In-Reply-To: <1167575429.1320.24.camel@ikaros.oook.cz> References: <200612310434.kBV4YRXS037540@repoman.freebsd.org> <1167575429.1320.24.camel@ikaros.oook.cz> X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.10.6; i386-portbld-freebsd6.1) Mime-Version: 1.0 Content-Type: multipart/signed; boundary=Sig_Cq1SXmT3yI1uwpsxtQ7dYoO; protocol="application/pgp-signature"; micalg=PGP-SHA1 Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/Mk bsd.wx.mk X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Dec 2006 17:04:37 -0000 --Sig_Cq1SXmT3yI1uwpsxtQ7dYoO Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Sun, 31 Dec 2006 15:30:29 +0100 Pav Lucistnik wrote: > > - Remove _WX_ILLEGAL_VERS_* added in the last update to 2.8. The reas= on is > > that each port should choose the version it can use, that includes = taking > > into account available components (also this brings much more chick= en and > > egg problems so the code could get really messy). >=20 > I have reverted this. It's needed as long as you want to let people use > ranges like 2.4+ together with python component, etc. >=20 It is complex to do that (if you want to do it the right way), because you need to parse components and dependencies before selecting a version. The current code is wrong since it will only reject components without dependency type specifications (and if there were dependencies then it will also ignore them). I think people should select the versions that actually work with the port, that's why the version specification string is so flexible. Also, if versions with invalid components are removed then the reported error if a user writes USE_WX=3D2.4 and WX_COMPS=3Dsvg would be "selected a null or invalid WxWidgets version" instead of "selected a WxWidgets component (${_WX_COMP}) which is not available for the selected version (${_WX_VER})". > If you disagree with me, please do it so it errors out with IGNORE > message, instead of creating a broken dependency line. >=20 It defines IGNORE _and_ adds the broken dependency line. I can add a "&& !defined(IGNORE)" before adding the wrong component to the list, but I thought IGNORE was checked when building INDEX. >=20 > Also, the auto-detection does not seem to work: >=20 > [Makefile] > USE_WX=3D 2.4+ > WX_COMPS=3D wx >=20 > [pkg_info] > wxgtk2-common-2.6.3_1/ > wxgtk2-unicode-2.6.3_1/ > wxgtk2-2.6.3_1/ >=20 > $ make -V LIB_DEPENDS > wx_base-2.8:/usr/ports/x11-toolkits/wxgtk28 >=20 > What gives? >=20 Sorry, I re-wrote it many times and forgot this: -_WX_VER_INSTALLED:=3D ${_HAVE_WX} +_WX_VER_INSTALLED:=3D ${_HAVE_WX:Mwx-*:S/wx-//} Best Regards, Ale --Sig_Cq1SXmT3yI1uwpsxtQ7dYoO Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (FreeBSD) iD8DBQFFl+doiV05EpRcP2ERAgumAJoCJbWEnpN2tG8G1qpA8cD8OZdcKwCbBbDz jdmTdyckwza4yeqF+jIs4kw= =9xGx -----END PGP SIGNATURE----- --Sig_Cq1SXmT3yI1uwpsxtQ7dYoO--