From owner-cvs-src@FreeBSD.ORG Tue Aug 23 07:40:05 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 22A2B16A41F; Tue, 23 Aug 2005 07:40:05 +0000 (GMT) (envelope-from bde@zeta.org.au) Received: from mailout1.pacific.net.au (mailout1.pacific.net.au [61.8.0.84]) by mx1.FreeBSD.org (Postfix) with ESMTP id 852EB43D45; Tue, 23 Aug 2005 07:40:04 +0000 (GMT) (envelope-from bde@zeta.org.au) Received: from mailproxy1.pacific.net.au (mailproxy1.pacific.net.au [61.8.0.86]) by mailout1.pacific.net.au (8.13.4/8.13.4/Debian-3) with ESMTP id j7N7e2Xl005349; Tue, 23 Aug 2005 17:40:02 +1000 Received: from katana.zip.com.au (katana.zip.com.au [61.8.7.246]) by mailproxy1.pacific.net.au (8.13.4/8.13.4/Debian-3) with ESMTP id j7N7dos0019953; Tue, 23 Aug 2005 17:39:50 +1000 Date: Tue, 23 Aug 2005 17:39:49 +1000 (EST) From: Bruce Evans X-X-Sender: bde@delplex.bde.org To: Suleiman Souhlal In-Reply-To: <55E14A30-FB7A-4F3A-9EC5-D9CECFFB3416@FreeBSD.org> Message-ID: <20050823172734.Q70244@delplex.bde.org> References: <200508212206.j7LM6fGR076152@repoman.freebsd.org> <43094CA1.8020905@samsco.org> <55E14A30-FB7A-4F3A-9EC5-D9CECFFB3416@FreeBSD.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, Scott Long , src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/ufs/ffs ffs_vfsops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Aug 2005 07:40:05 -0000 On Mon, 22 Aug 2005, Suleiman Souhlal wrote: > On Aug 22, 2005, at 5:55 AM, Scott Long wrote: > >> Suleiman Souhlal wrote: >> >>> ssouhlal 2005-08-21 22:06:41 UTC >>> FreeBSD src repository >>> Modified files: >>> sys/ufs/ffs ffs_vfsops.c Log: >>> Set the mountpoint path in the superblock (fs_fsmnt) at mount-time >>> so that it appears in the various messages (not cleanly unmounted, >>> filesystem full, etc). This has been broken since rev 1.261. >>> Revision Changes Path >>> 1.292 +2 -1 src/sys/ufs/ffs/ffs_vfsops.c >>> >> >> What was wrong with vfs_mountedfrom()? > > The string it expects is the path to a device, and not to a mountpoint. > We already call it in ffs_mount() with the right path. The main difference is actually that vfs_mountedfrom() copies from ffs to vfs, but copying from vfs to ffs is wanted. The direction of the copy is verbosely documented in a comment immediately before the code: /* * Set FS local "last mounted on" information (NULL pad) */ ^^^^^^^^ ^^^^^^^^^^ The largest of the style bugs in rev.1.261 was that it left this comment not even echoing the code. Bruce