From owner-svn-ports-head@FreeBSD.ORG Tue May 21 16:28:36 2013 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 3AD643E6; Tue, 21 May 2013 16:28:36 +0000 (UTC) (envelope-from bsam@passap.ru) Received: from forward14.mail.yandex.net (forward14.mail.yandex.net [IPv6:2a02:6b8:0:801::4]) by mx1.freebsd.org (Postfix) with ESMTP id E4F18CFB; Tue, 21 May 2013 16:28:35 +0000 (UTC) Received: from smtp13.mail.yandex.net (smtp13.mail.yandex.net [95.108.130.68]) by forward14.mail.yandex.net (Yandex) with ESMTP id 479F51981A0A; Tue, 21 May 2013 20:28:34 +0400 (MSK) Received: from smtp13.mail.yandex.net (localhost [127.0.0.1]) by smtp13.mail.yandex.net (Yandex) with ESMTP id C6C11E407A0; Tue, 21 May 2013 20:28:33 +0400 (MSK) Received: from 87.249.28.58.tel.ru (87.249.28.58.tel.ru [87.249.28.58]) by smtp13.mail.yandex.net (nwsmtp/Yandex) with ESMTP id CffdgpSex1-SXYaQjcl; Tue, 21 May 2013 20:28:33 +0400 Message-ID: <519BA0B0.7010700@passap.ru> Date: Tue, 21 May 2013 20:28:32 +0400 From: Boris Samorodov User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:17.0) Gecko/20130518 Thunderbird/17.0.6 MIME-Version: 1.0 To: Alexey Dokuchaev Subject: Re: svn commit: r318592 - head/benchmarks/mdtest References: <201305201043.r4KAhCKv031239@svn.freebsd.org> <20130521023448.GA3541@FreeBSD.org> In-Reply-To: <20130521023448.GA3541@FreeBSD.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, Boris Samorodov , ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 May 2013 16:28:36 -0000 21.05.2013 06:34, Alexey Dokuchaev пишет: > On Mon, May 20, 2013 at 10:43:12AM +0000, Boris Samorodov wrote: >> New Revision: 318592 >> URL: http://svnweb.freebsd.org/changeset/ports/318592 >> >> do-install: >> - ${INSTALL_PROGRAM} ${WRKSRC}/${PORTNAME} ${PREFIX}/bin >> - ${INSTALL_MAN} ${WRKSRC}/${PORTNAME}.1 ${MANPREFIX}/man/man1 >> + (cd ${WRKSRC} && ${INSTALL_PROGRAM} ${PORTNAME} ${PREFIX}/bin) >> + (cd ${WRKSRC} && ${INSTALL_MAN} ${PORTNAME}.1 ${MANPREFIX}/man/man1) >> .if ${PORT_OPTIONS:MEXAMPLES} >> @${MKDIR} ${EXAMPLESDIR} >> - @(cd ${WRKSRC}/scripts && ${COPYTREE_SHARE} \* ${EXAMPLESDIR}) >> + (cd ${WRKSRC}/scripts && ${INSTALL_DATA} * ${EXAMPLESDIR}) > > These changes are gratuitous (at least), plus I've already raised my > concerns about Kato's desire to make every INSTALL_* command needlessly > depended on current directory. Not just it makes command line longer, > it looks worse it logs and requires reader to parse two command instead > of one. I am also not convinced that using subshell is required. > > Asterisk should have been replaced with dot as a safer alternative that > is not special shell symbol and thus does not require escaping (or worry > about it). > > Given that changes are probably technically correct (Kato is usually good > on that side), I would like to reinterate that their (or whomever else) > submissions should not be committed blindly as they are. First of all this particular commit was not a blind one. And I suspected that a discussion may take place. Then I'd say that for me the current state of Makefile is more readable and more logical: ----- do-build: (cd ${WRKSRC} && ${MPICC} ${CFLAGS} -o ${PORTNAME} ${PORTNAME}.c -lm) do-install: (cd ${WRKSRC} && ${INSTALL_PROGRAM} ${PORTNAME} ${PREFIX}/bin) (cd ${WRKSRC} && ${INSTALL_MAN} ${PORTNAME}.1 ${MANPREFIX}/man/man1) .if ${PORT_OPTIONS:MEXAMPLES} @${MKDIR} ${EXAMPLESDIR} (cd ${WRKSRC}/scripts && ${INSTALL_DATA} * ${EXAMPLESDIR}) .endif ----- Said that I don't have a strong position on the matter. If any official recommendation happen I'll obey it. Thanks! -- WBR, Boris Samorodov (bsam) FreeBSD Committer, http://www.FreeBSD.org The Power To Serve