From owner-cvs-all@FreeBSD.ORG  Thu May 29 21:47:56 2008
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 31EB71065675;
	Thu, 29 May 2008 21:47:56 +0000 (UTC)
	(envelope-from itetcu@FreeBSD.org)
Received: from it.buh.tecnik93.com (it.buh.tecnik93.com [81.196.204.98])
	by mx1.freebsd.org (Postfix) with ESMTP id C34458FC1D;
	Thu, 29 May 2008 21:47:55 +0000 (UTC)
	(envelope-from itetcu@FreeBSD.org)
Received: from it.buh.tecnik93.com (localhost [127.0.0.1])
	by it.buh.tecnik93.com (Postfix) with ESMTP id AE03C2C50CC2;
	Fri, 30 May 2008 00:47:50 +0300 (EEST)
Date: Fri, 30 May 2008 00:47:41 +0300
From: Ion-Mihai Tetcu <itetcu@FreeBSD.org>
To: Mathieu Arnold <mat@FreeBSD.org>
Message-ID: <20080530004741.1d6c6961@it.buh.tecnik93.com>
In-Reply-To: <CDAB9D85B4E3C5836BB2270F@atuin.in.mat.cc>
References: <200805292057.m4TKv4in005942@repoman.freebsd.org>
	<20080530001727.50090f20@it.buh.tecnik93.com>
	<CDAB9D85B4E3C5836BB2270F@atuin.in.mat.cc>
X-Mailer: Claws Mail 3.4.0 (GTK+ 2.12.9; i386-portbld-freebsd7.0)
Mime-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/LSwc1.=p_bwaa2W+ywf0wc.";
	protocol="application/pgp-signature"; micalg=PGP-SHA1
Cc: Mathieu Arnold <mat@FreeBSD.org>, cvs-ports@FreeBSD.org,
	cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject: Re: NOPORTDOCS != NOPORTEXAMPLES != NOPORTDATA (Re: cvs commit: 
 ports/databases/php4-rrdtool Makefile)
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 29 May 2008 21:47:56 -0000

--Sig_/LSwc1.=p_bwaa2W+ywf0wc.
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

On Thu, 29 May 2008 23:23:33 +0200
Mathieu Arnold <mat@FreeBSD.org> wrote:

> +-Le 30/05/08 00:17 +0300, Ion-Mihai Tetcu a dit :
> | On Thu, 29 May 2008 20:57:04 +0000 (UTC)
> | Mathieu Arnold <mat@FreeBSD.org> wrote:
> |=20
> |> mat         2008-05-29 20:57:03 UTC
> |>=20
> |>   FreeBSD ports repository
> |>=20
> |>   Modified files:
> |>     databases/php4-rrdtool Makefile=20
> |>   Log:
> |>   Fix when NOPORTDOCS set
> |>  =20
> |>   Spotted By:     itetcu
> |>  =20
> |>   Revision  Changes    Path
> |>   1.6       +2 -0      ports/databases/php4-rrdtool/Makefile
> |=20
> | No, please be careful:
> |=20
> | We have 3 vars that control installation of "non-essential" files:
> | NOPORTDOCS, NOPORTEXAMPLES, NOPORTDATA
> |=20
> | +.if !defined(NOPORTDOCS)
> |  post-install:
> |  	@${MKDIR} ${EXAMPLESDIR}
> |  	@${INSTALL_DATA} ${WRKSRC}/examples/* ${EXAMPLESDIR}
> |  	@${ECHO_MSG} "=3D=3D=3D> Examples installed in ${EXAMPLESDIR}."
> | +.endif
> |=20
> | Since here you install examples you should test for NOPORTEXAMPLES.
>=20
> Well, the plist has %%PORTDOCS%% so, I've added whatever was necessary to
> remain consistent. I can s/PORTDOCS/PORTEXAMPLES/ if you prefer.

Let's try to be consistent with the way things are supposed to work, ok?

So yes, please test for NOPORTEXAMPLES both in Makefile and change the
appropriate lines in pkg-plist.


Thanks,

--=20
IOnut - Un^d^dregistered ;) FreeBSD "user"
  "Intellectual Property" is   nowhere near as valuable   as "Intellect"
FreeBSD committer -> itetcu@FreeBSD.org, PGP Key ID 057E9F8B493A297B

--Sig_/LSwc1.=p_bwaa2W+ywf0wc.
Content-Type: application/pgp-signature; name=signature.asc
Content-Disposition: attachment; filename=signature.asc

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (FreeBSD)

iEYEARECAAYFAkg/JIQACgkQJ7GIuiH/oeUBCQCfU8vkYM6Nfwoe4/woP8xj9j20
fmgAoJWW74nepulSh9ycXqjPZyoA8TlF
=/NJR
-----END PGP SIGNATURE-----

--Sig_/LSwc1.=p_bwaa2W+ywf0wc.--