From owner-cvs-all@FreeBSD.ORG Fri Dec 21 02:06:59 2007 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 43DA916A417 for ; Fri, 21 Dec 2007 02:06:59 +0000 (UTC) (envelope-from kabaev@gmail.com) Received: from an-out-0708.google.com (an-out-0708.google.com [209.85.132.247]) by mx1.freebsd.org (Postfix) with ESMTP id DCF2613C4D5 for ; Fri, 21 Dec 2007 02:06:58 +0000 (UTC) (envelope-from kabaev@gmail.com) Received: by an-out-0708.google.com with SMTP id c14so33616anc.13 for ; Thu, 20 Dec 2007 18:06:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:cc:subject:message-id:in-reply-to:references:x-mailer:mime-version:content-type; bh=erwvkA1zX1jbnLvxjjfoJyzCqnZYGj9MNIUJZFIYYfc=; b=qW3D4dzoy7zmc+n6QjG1aZB3ldYvExrscVGUU00f5MDZdOITZXbdIokStu6kNAoHQxFR69FSMFct+u1GVt/kzorOAaF5pohEZr8wEiR2717UG5M5TBqm0iU6eKgXUGoibX5HTRFUjYqWoGUTOVQEnk+p+ph1gb5e41V4kHxY9h4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:in-reply-to:references:x-mailer:mime-version:content-type; b=L1y9ZfZSQyFt7PA2E6rAQRjFXVdDj2PdMx5JpmV+y+m+uU4fBLczHWQKMaYMiPUquwblvpglWfxWQg6o1SiPYCc5RqYPqaKgigd7iOizY851x+g8hHoRFfXLFz8PGaxmxpioxfL9VhlJK/kJbSSJHxuB/2d2nyinujmFN+YNWCQ= Received: by 10.100.247.14 with SMTP id u14mr1397136anh.90.1198202816960; Thu, 20 Dec 2007 18:06:56 -0800 (PST) Received: from kan.dnsalias.net ( [24.218.183.247]) by mx.google.com with ESMTPS id g7sm634086wra.13.2007.12.20.18.06.54 (version=SSLv3 cipher=OTHER); Thu, 20 Dec 2007 18:06:55 -0800 (PST) Date: Thu, 20 Dec 2007 21:06:50 -0500 From: Alexander Kabaev To: d@delphij.net Message-ID: <20071220210650.4f3d061d@kan.dnsalias.net> In-Reply-To: <476B126B.40004@delphij.net> References: <200712200432.lBK4WSEq036881@repoman.freebsd.org> <20071220074756.5ac4b0c1@kan.dnsalias.net> <476B126B.40004@delphij.net> X-Mailer: Claws Mail 3.0.2 (GTK+ 2.12.1; i386-portbld-freebsd7.0) Mime-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/8SkNbvXIURNAzjMNqET3OYW"; protocol="application/pgp-signature"; micalg=PGP-SHA1 Cc: cvs-src@FreeBSD.ORG, src-committers@FreeBSD.ORG, delphij@delphij.net, David Xu , cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/lib/libthr pthread.map src/lib/libthr/thread thr_syscalls.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Dec 2007 02:06:59 -0000 --Sig_/8SkNbvXIURNAzjMNqET3OYW Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Thu, 20 Dec 2007 17:10:03 -0800 Xin LI wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 >=20 > Hi, Alexander, >=20 > Alexander Kabaev wrote: > > On Thu, 20 Dec 2007 04:32:28 +0000 (UTC) > > David Xu wrote: > >=20 > >> davidxu 2007-12-20 04:32:28 UTC > >> > >> FreeBSD src repository > >> > >> Modified files: > >> lib/libthr pthread.map=20 > >> lib/libthr/thread thr_syscalls.c=20 > >> Log: > >> Remove vfork() overloading, it is no longer needed. > >> =20 > >> Revision Changes Path > >> 1.21 +0 -2 src/lib/libthr/pthread.map > >> 1.17 +0 -9 src/lib/libthr/thread/thr_syscalls.c > >> > >> http://cvsweb.FreeBSD.org/src/lib/libthr/pthread.map.diff?r1=3D1.20&r2= =3D1.21 > >> http://cvsweb.FreeBSD.org/src/lib/libthr/thread/thr_syscalls.c.diff?r1= =3D1.16&r2=3D1.17 > >=20 > > Technically, you just broke ABI backwards compatibility for libthr. > > Symbols can not be removed from exported sections on a whim. =20 >=20 > Being relatively new to this stuff, I think I get confused by this, so > we can link to libthr's "vfork" directly? It uses the same namespace > as libc did... >=20 > Maybe we should write up some usage guidelines for this in developers' > handbook (I can give this a shot)... >=20 The change does not break existing binaries, as libc will satisfy all references after fork symbol was removed from libthr. It just breaks general rule: we do not remove versioned symbols once they were released unless there's a library version bump. --=20 Alexander Kabaev --Sig_/8SkNbvXIURNAzjMNqET3OYW Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (FreeBSD) iD8DBQFHax+6Q6z1jMm+XZYRAvG/AJ0aIOAv8E3rFMhzdCQukvb4pqZDZgCdGy6Q 6FD2iw8VT4CKELdtmR9mvZc= =tI+x -----END PGP SIGNATURE----- --Sig_/8SkNbvXIURNAzjMNqET3OYW--