From owner-freebsd-current@FreeBSD.ORG  Sat Apr 14 14:27:15 2007
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: freebsd-current@freebsd.org
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 9361416A403
	for <freebsd-current@freebsd.org>; Sat, 14 Apr 2007 14:27:15 +0000 (UTC)
	(envelope-from freebsd@gm.nunu.org)
Received: from py-out-1112.google.com (py-out-1112.google.com [64.233.166.183])
	by mx1.freebsd.org (Postfix) with ESMTP id 4676313C43E
	for <freebsd-current@freebsd.org>; Sat, 14 Apr 2007 14:27:15 +0000 (UTC)
	(envelope-from freebsd@gm.nunu.org)
Received: by py-out-1112.google.com with SMTP id f31so844548pyh
	for <freebsd-current@freebsd.org>; Sat, 14 Apr 2007 07:27:14 -0700 (PDT)
Received: by 10.35.69.11 with SMTP id w11mr7269147pyk.1176559295496;
	Sat, 14 Apr 2007 07:01:35 -0700 (PDT)
Received: by 10.35.52.3 with HTTP; Sat, 14 Apr 2007 07:01:35 -0700 (PDT)
Message-ID: <626eb4530704140701n3b06df02o58f288baad4cf3d1@mail.gmail.com>
Date: Sat, 14 Apr 2007 23:01:35 +0900
From: "Hidetoshi Shimokawa" <simokawa@FreeBSD.ORG>
Sender: freebsd@gm.nunu.org
To: "Pawel Jakub Dawidek" <pjd@freebsd.org>
In-Reply-To: <20070414134653.GF10527@garage.freebsd.pl>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <86slb3t74o.wl%simokawa@FreeBSD.ORG>
	<20070414134653.GF10527@garage.freebsd.pl>
X-Google-Sender-Auth: 80cc80ac6f3f812c
Cc: freebsd-current@freebsd.org
Subject: Re: zdb patch
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 14 Apr 2007 14:27:15 -0000

On 4/14/07, Pawel Jakub Dawidek <pjd@freebsd.org> wrote:
> On Sat, Apr 14, 2007 at 10:31:19PM +0900, Hidetoshi Shimokawa wrote:
> > Here is a patch for zdb.
> > Now we can 'zdb -u pool' :-)
> >
> > ==== //depot/user/simokawa/firewire/contrib/opensolaris/lib/libzpool/common/kernel.c#2 - /home/p4/firewire/contrib/opensolaris/lib/libzpool/common/kernel.c ====
> > @@ -38,6 +38,7 @@
> >  #include <sys/zfs_context.h>
> >  #include <sys/zmod.h>
> >  #include <sys/utsname.h>
> > +#include <sys/disk.h>
> >
> >  /*
> >   * Emulation of kernel services in userland.
> > @@ -291,7 +292,11 @@
> >
> >       ASSERT(abstime > 0);
> >  top:
> > +#if 0
> >       delta = abstime - lbolt;
> > +#else /* for compatibility with FreeBSD kernel */
> > +     delta = abstime;
> > +#endif
>
> What is this change for? It works ok without it here.

It is necessary for userland because of your change 104486.
(see p4 describe 104486)

Without above patch, cv_timedwait() never sleeps and arc_reclaim_thread
never releases the lock.


-- 
/\ Hidetoshi Shimokawa
\/  simokawa@FreeBSD.ORG