From owner-freebsd-doc@FreeBSD.ORG  Sat Jun  2 02:50:16 2012
Return-Path: <owner-freebsd-doc@FreeBSD.ORG>
Delivered-To: freebsd-doc@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 77AE1106566B
	for <freebsd-doc@freebsd.org>; Sat,  2 Jun 2012 02:50:16 +0000 (UTC)
	(envelope-from gjb@FreeBSD.org)
Received: from glenbarber.us (onyx.glenbarber.us [199.48.134.227])
	by mx1.freebsd.org (Postfix) with SMTP id 38D6F8FC15
	for <freebsd-doc@freebsd.org>; Sat,  2 Jun 2012 02:50:16 +0000 (UTC)
Received: (qmail 78680 invoked by uid 0); 1 Jun 2012 22:50:15 -0400
Received: from unknown (HELO glenbarber.us) (76.124.49.145)
	by 0 with SMTP; 1 Jun 2012 22:50:15 -0400
Date: Fri, 1 Jun 2012 22:50:13 -0400
From: Glen Barber <gjb@FreeBSD.org>
To: Ulrich =?iso-8859-1?Q?Sp=F6rlein?= <uqs@freebsd.org>
Message-ID: <20120602025013.GD1377@glenbarber.us>
References: <20120601175450.GO10094@acme.spoerlein.net>
	<alpine.BSF.2.00.1206011950340.92108@wonkity.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <alpine.BSF.2.00.1206011950340.92108@wonkity.com>
X-Operating-System: FreeBSD 10.0-CURRENT amd64
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: freebsd-doc@freebsd.org
Subject: Re: Please review WINE chapter addition and linuxemu rename
X-BeenThere: freebsd-doc@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Documentation project <freebsd-doc.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-doc>,
	<mailto:freebsd-doc-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-doc>
List-Post: <mailto:freebsd-doc@freebsd.org>
List-Help: <mailto:freebsd-doc-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-doc>,
	<mailto:freebsd-doc-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 02 Jun 2012 02:50:16 -0000

Hi,

On Fri, Jun 01, 2012 at 08:05:09PM -0600, Warren Block wrote:
> On Fri, 1 Jun 2012, Ulrich Spörlein wrote:
> 
> > in the process of adding the WINE section from the wiki to the handbook
> > (GCIN 2011 project, yeah I know, I was rather busy ...), I also took the
> > liberty of renaming it from linuxemu to compat. Also in the hope that
> > someday we might have a blurp on SVR4 compatibility, although I guess no
> > one is really interested in that.
> >
> > Anyway, please review the proposed changes at
> > https://github.com/uqs/freebsd-doc/commits/wine
> > or clone that branch and have a closer look.
> 
> Like Gabor suggested, a single diff makes it easier to see all that has 
> changed.
> 
> > Rendering of that branch can be found here:
> > https://www.spoerlein.net/handbook/compat.html
> 
> Just looking at the WINE section:
> 
>    "check the Wine AppDB on their main website."
> 
> "their main website" could be removed.
> 
> Those <programlistings> should be <screen> sections:
> 
> <screen>&prompt.root; <userinput>chroot /compat/i386</userinput>
> &prompt.root; /etc/rc.d/ldconfig start</screen>
> 
> And so on.  Note that the ending tag should go on the last line of 
> output.  If it is on a line of its own, there's an extra blank line in 
> the rendered version.
> 

To add to Warren's style comments, there should be an empty line between
<title> and <para>.  Similarly for <sect> tags.

The closing </para> tags should not be on a separate line alone.

It might be good to use &quot; in place of literal double quotes
surrounding Wine is not an Emulator.

"make install clean" could be sgml-ified as:

<command>make</command> <maketarget>install clean</maketarget>

without quotes.

Regards,

Glen