From owner-freebsd-ports-bugs@FreeBSD.ORG  Thu Feb 22 15:40:08 2007
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
X-Original-To: freebsd-ports-bugs@hub.freebsd.org
Delivered-To: freebsd-ports-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 5603416A413
	for <freebsd-ports-bugs@hub.freebsd.org>;
	Thu, 22 Feb 2007 15:40:08 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [69.147.83.40])
	by mx1.freebsd.org (Postfix) with ESMTP id 1E89013C46B
	for <freebsd-ports-bugs@hub.freebsd.org>;
	Thu, 22 Feb 2007 15:40:08 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id l1MFe7LP006893
	for <freebsd-ports-bugs@freefall.freebsd.org>;
	Thu, 22 Feb 2007 15:40:07 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.13.4/8.13.4/Submit) id l1MFe7xQ006892;
	Thu, 22 Feb 2007 15:40:07 GMT (envelope-from gnats)
Resent-Date: Thu, 22 Feb 2007 15:40:07 GMT
Resent-Message-Id: <200702221540.l1MFe7xQ006892@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-ports-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
	Oleg Lomaka<oleg.lomaka@gmail.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 11DC816A41F
	for <freebsd-gnats-submit@FreeBSD.org>;
	Thu, 22 Feb 2007 15:36:12 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [69.147.83.33])
	by mx1.freebsd.org (Postfix) with ESMTP id E8F8913C4AC
	for <freebsd-gnats-submit@FreeBSD.org>;
	Thu, 22 Feb 2007 15:36:11 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id l1MFaB9r086566
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 22 Feb 2007 15:36:11 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id l1MFaBNr086564;
	Thu, 22 Feb 2007 15:36:11 GMT (envelope-from nobody)
Message-Id: <200702221536.l1MFaBNr086564@www.freebsd.org>
Date: Thu, 22 Feb 2007 15:36:11 GMT
From: Oleg Lomaka<oleg.lomaka@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-3.0
Cc: 
Subject: ports/109436: net/rdesktop segmentation fault
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 22 Feb 2007 15:40:08 -0000


>Number:         109436
>Category:       ports
>Synopsis:       net/rdesktop segmentation fault
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Feb 22 15:40:07 GMT 2007
>Closed-Date:
>Last-Modified:
>Originator:     Oleg Lomaka
>Release:        RELENG_6
>Organization:
>Environment:
6.2-STABLE FreeBSD 6.2-STABLE #6: Wed Jan 17 10:22:07 EET 2007 i386
>Description:
net/rdesktop segmentation fault in file xclip.c line 210
function lf2crlf, on line '*o++ = '\0';'
>How-To-Repeat:
Occasionally when work with VMWare on remote Windows workstation
>Fix:


Patch attached with submission follows:

--- xclip.c.orig	Mon Aug  7 14:45:43 2006
+++ xclip.c	Thu Feb 22 17:24:58 2007
@@ -207,7 +207,7 @@
 	*length = o - result;
 
 	/* Convenience */
-	*o++ = '\0';
+	if (*length > 0) *o++ = '\0';
 
 	return result;
 }
@@ -288,6 +288,10 @@
 {
 	DEBUG_CLIPBOARD(("xclip_send_data_with_convert: target=%s, size=%u\n",
 			 XGetAtomName(g_display, target), (unsigned) source_size));
+	if (source == 0)
+	{
+		return False;
+	}
 
 #ifdef USE_UNICODE_CLIPBOARD
 	if (target == format_string_atom ||

>Release-Note:
>Audit-Trail:
>Unformatted: