From owner-freebsd-hackers@FreeBSD.ORG Mon Nov 9 01:19:13 2009 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5C03A106566C for ; Mon, 9 Nov 2009 01:19:13 +0000 (UTC) (envelope-from a_best01@uni-muenster.de) Received: from zivm-exrelay1.uni-muenster.de (ZIVM-EXRELAY1.UNI-MUENSTER.DE [128.176.192.14]) by mx1.freebsd.org (Postfix) with ESMTP id B4BC38FC13 for ; Mon, 9 Nov 2009 01:19:12 +0000 (UTC) X-IronPort-AV: E=Sophos;i="4.44,705,1249250400"; d="txt'?scan'208";a="287743941" Received: from zivmaildisp1.uni-muenster.de (HELO ZIVMAILUSER04.UNI-MUENSTER.DE) ([128.176.188.85]) by zivm-relay1.uni-muenster.de with ESMTP; 09 Nov 2009 02:19:11 +0100 Received: by ZIVMAILUSER04.UNI-MUENSTER.DE (Postfix, from userid 149459) id 9323B1B07BE; Mon, 9 Nov 2009 02:19:11 +0100 (CET) Date: Mon, 09 Nov 2009 02:19:05 +0100 (CET) From: Alexander Best Sender: Organization: Westfaelische Wilhelms-Universitaet Muenster To: Gabor Kovesdan Message-ID: In-Reply-To: <4AF76A2C.400@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary=+permail-2009110901190580e26a0b0000354f-a_best01+ Cc: freebsd-hackers@FreeBSD.org Subject: Re: [patch] burncd: honour for envar SPEED X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Nov 2009 01:19:13 -0000 This is a MIME encoded multipart message. --+permail-2009110901190580e26a0b0000354f-a_best01+ Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Gabor Kovesdan schrieb am 2009-11-09: > Gabor Kovesdan escribi=F3: > >Alexander Best escribi=F3: > >>any thoughts on these small changes to burncd? > >> - int nogap =3D 0, speed =3D 4 * 177, test_write =3D 0, force =3D 0= ; > >>+ int nogap =3D 0, speed =3D 0, test_write =3D 0, force =3D 0; > >> int block_size =3D 0, block_type =3D 0, cdopen =3D 0, dvdrw =3D 0; > >> const char *dev; > >> if ((dev =3D getenv("CDROM")) =3D=3D NULL) > >> dev =3D "/dev/acd0"; > >>+ if ((speed =3D getenv("SPEED")) =3D=3D NULL) > >>+ speed =3D 4 * 177; > >>+ > >It seems incorrect. The speed variable is of type int, while getenv > >returns char *. You should first assign getenv("SPEED") to a char * > >variable and if it isn't NULL then you should convert it to int or > >fall back to the default value otherwise. > And one more thing. Personally, I think that a more > specific/descriptive name would be better, e.g. BURNCD_SPEED. SPEED > is just too general. > -- > Gabor Kovesdan > FreeBSD Volunteer > EMAIL: gabor@FreeBSD.org .:|:. gabor@kovesdan.org > WEB: http://people.FreeBSD.org/~gabor .:|:. http://kovesdan.org thanks for the help. how about this revised patch? cheers. alex --+permail-2009110901190580e26a0b0000354f-a_best01+ Content-Type: text/plain Content-Transfer-Encoding: Base64 Content-Disposition: attachment; filename="burncdspeedpatch.txt" SW5kZXg6IHVzci5zYmluL2J1cm5jZC9idXJuY2QuOAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSB1c3Iuc2Jpbi9i dXJuY2QvYnVybmNkLjgJKHJldmlzaW9uIDE5OTA2NCkKKysrIHVzci5zYmluL2J1cm5jZC9idXJu Y2QuOAkod29ya2luZyBjb3B5KQpAQCAtMTY0LDYgKzE2NCwxMiBAQAogLkZsIGYKIGZsYWcuCiAu RWwKKy5CbCAtdGFnIC13aWR0aCAiLkV2IFdSSVRFX1NQRUVEIgorLkl0IEV2IFdSSVRFX1NQRUVE CitUaGUgd3JpdGUgc3BlZWQgdG8gdXNlIGlmIG9uZSBpcyBub3Qgc3BlY2lmaWVkIHdpdGggdGhl CisuRmwgcworZmxhZy4KKy5FbAogLlNoIEZJTEVTCiAuQmwgLXRhZyAtd2lkdGggIi5QYSAvZGV2 L2FjZDAiCiAuSXQgUGEgL2Rldi9hY2QwCkluZGV4OiB1c3Iuc2Jpbi9idXJuY2QvYnVybmNkLmMK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gdXNyLnNiaW4vYnVybmNkL2J1cm5jZC5jCShyZXZpc2lvbiAxOTkwNjQp CisrKyB1c3Iuc2Jpbi9idXJuY2QvYnVybmNkLmMJKHdvcmtpbmcgY29weSkKQEAgLTgwLDExICs4 MCwyMCBAQAogCWludCBkYW8gPSAwLCBlamVjdCA9IDAsIGZpeGF0ZSA9IDAsIGxpc3QgPSAwLCBt dWx0aSA9IDAsIHByZWVtcCA9IDA7CiAJaW50IG5vZ2FwID0gMCwgc3BlZWQgPSA0ICogMTc3LCB0 ZXN0X3dyaXRlID0gMCwgZm9yY2UgPSAwOwogCWludCBibG9ja19zaXplID0gMCwgYmxvY2tfdHlw ZSA9IDAsIGNkb3BlbiA9IDAsIGR2ZHJ3ID0gMDsKLQljb25zdCBjaGFyICpkZXY7CisJY29uc3Qg Y2hhciAqZGV2LCAqZW52X3NwZWVkOwogCiAJaWYgKChkZXYgPSBnZXRlbnYoIkNEUk9NIikpID09 IE5VTEwpCiAJCWRldiA9ICIvZGV2L2FjZDAiOwogCisJaWYgKChlbnZfc3BlZWQgPSBnZXRlbnYo IldSSVRFX1NQRUVEIikpICE9IE5VTEwpCisJCWlmIChzdHJjYXNlY21wKCJtYXgiLCBnZXRlbnYp ID09IDApCisJCQlzcGVlZCA9IENEUl9NQVhfU1BFRUQ7CisJCWVsc2UKKwkJCXNwZWVkID0gYXRv aShlbnZfc3BlZWQpICogMTc3OworCQlpZiAoc3BlZWQgPD0gMCkKKwkJCWVycngoRVhfVVNBR0Us ICJJbnZhbGlkIHNwZWVkOiAlcyIsIGVudl9zcGVlZCk7CisJfQorCiAJd2hpbGUgKChjaCA9IGdl dG9wdChhcmdjLCBhcmd2LCAiZGVmOkZsbW5wcXM6dHYiKSkgIT0gLTEpIHsKIAkJc3dpdGNoIChj aCkgewogCQljYXNlICdkJzoK --+permail-2009110901190580e26a0b0000354f-a_best01+--