From owner-cvs-all@FreeBSD.ORG  Fri Jul  4 13:28:47 2008
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@FreeBSD.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
	id 6A4E11065678; Fri,  4 Jul 2008 13:28:47 +0000 (UTC)
Date: Fri, 4 Jul 2008 13:28:47 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Pietro Cerutti <gahr@FreeBSD.org>
Message-ID: <20080704132847.GA21540@FreeBSD.org>
References: <200807031840.m63Ier8s004961@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <200807031840.m63Ier8s004961@repoman.freebsd.org>
User-Agent: Mutt/1.4.2.1i
Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/editors/codelite Makefile distinfo pkg-plist
	ports/editors/codelite/files patch-configure
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 04 Jul 2008 13:28:47 -0000

On Thu, Jul 03, 2008 at 06:40:53PM +0000, Pietro Cerutti wrote:
> gahr        2008-07-03 18:40:53 UTC
> 
>   FreeBSD ports repository
> 
>   Modified files:
>     editors/codelite     Makefile distinfo pkg-plist 
>     editors/codelite/files patch-configure 
>   Log:
>   - Update to 1.0

Some quick observations:

- You've left PORTREVISION, which is porbably unnecessary
- Bad indent of WRKSRC assignment
- Ditto for USE_WX
- You've dropped GNU_CONFIGURE, and instroduced custom do-configure
  target which pretty much mimics default action.  If configure script
  is not GNU autotools generated and one cannot assume it would
  understand some common options (--prefix et al.), there's
  HAS_CONFIGURE knob for that in bpm
- Most directories are created with mkdir, some with install -d, which
  introduces certain inconsistency
- Ditto for trailing slashes for target directory names during
  installation (also, in pkg-plist)
- (cd ${WRKSRC}/Runtime/sdk/include/UnitTest++ &&  ${COPYTREE_SHARE} \*
						 ^^
  superfluous space here ------------------------++

./danfe