From owner-cvs-all@FreeBSD.ORG Sat May 3 18:57:53 2008 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 450A4106566C; Sat, 3 May 2008 18:57:53 +0000 (UTC) (envelope-from kientzle@freebsd.org) Received: from kientzle.com (h-66-166-149-50.snvacaid.covad.net [66.166.149.50]) by mx1.freebsd.org (Postfix) with ESMTP id DE2038FC24; Sat, 3 May 2008 18:57:52 +0000 (UTC) (envelope-from kientzle@freebsd.org) Received: from [10.0.0.128] (p54.kientzle.com [66.166.149.54]) by kientzle.com (8.12.9/8.12.9) with ESMTP id m43IIEtv024044; Sat, 3 May 2008 11:18:14 -0700 (PDT) (envelope-from kientzle@freebsd.org) Message-ID: <481CAC66.7030808@freebsd.org> Date: Sat, 03 May 2008 11:18:14 -0700 From: Tim Kientzle User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.12) Gecko/20060422 X-Accept-Language: en-us, en MIME-Version: 1.0 To: John Baldwin References: <200805021525.m42FP7GC055065@repoman.freebsd.org> In-Reply-To: <200805021525.m42FP7GC055065@repoman.freebsd.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/include stdio.h src/lib/libc/stdio Makefile.inc clrerr.c feof.c ferror.c fileno.c getc.c getchar.c local.h putc.c putchar.c unlocked.c xprintf.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 May 2008 18:57:53 -0000 This commit seems to be responsible for the last two days of trunk breakage. libftp directly accesses the _cookie field from a FILE * which was hidden by this commit. John Baldwin wrote: > jhb 2008-05-02 15:25:07 UTC > > FreeBSD src repository > > Modified files: > include stdio.h > lib/libc/stdio Makefile.inc clrerr.c feof.c ferror.c > fileno.c getc.c getchar.c local.h putc.c > putchar.c xprintf.c > Removed files: > lib/libc/stdio unlocked.c > Log: > Next round of stdio changes: Remove all inlining of stdio operations and > move the definition of the type backing FILE (struct __sFILE) into an > internal header. > - Remove macros to inline certain operations from stdio.h. Applications > will now always call the functions instead. > - Move the various foo_unlocked() functions from unlocked.c into foo.c. > This lets some of the inlining macros (e.g. __sfeof()) move into > foo.c. > - Update a few comments. > - struct __sFILE can now go back to using mbstate_t, pthread_t, and > pthread_mutex_t instead of knowing about their private, backing types. > > MFC after: 1 month > Reviewed by: kan > > Revision Changes Path > 1.65 +4 -172 src/include/stdio.h > 1.38 +1 -1 src/lib/libc/stdio/Makefile.inc > 1.11 +10 -1 src/lib/libc/stdio/clrerr.c > 1.11 +9 -1 src/lib/libc/stdio/feof.c > 1.11 +8 -2 src/lib/libc/stdio/ferror.c > 1.12 +9 -1 src/lib/libc/stdio/fileno.c > 1.15 +7 -2 src/lib/libc/stdio/getc.c > 1.14 +7 -2 src/lib/libc/stdio/getchar.c > 1.32 +132 -2 src/lib/libc/stdio/local.h > 1.15 +7 -2 src/lib/libc/stdio/putc.c > 1.15 +7 -2 src/lib/libc/stdio/putchar.c > 1.2 +0 -94 src/lib/libc/stdio/unlocked.c (dead) > 1.7 +3 -2 src/lib/libc/stdio/xprintf.c > >