From owner-freebsd-ports-bugs@FreeBSD.ORG Thu Aug 28 18:30:18 2003 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3A9E216A4BF for ; Thu, 28 Aug 2003 18:30:18 -0700 (PDT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id B6E1D43FDD for ; Thu, 28 Aug 2003 18:30:16 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.9/8.12.9) with ESMTP id h7T1UGUp018223 for ; Thu, 28 Aug 2003 18:30:16 -0700 (PDT) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.9/8.12.9/Submit) id h7T1UGv2018222; Thu, 28 Aug 2003 18:30:16 -0700 (PDT) Resent-Date: Thu, 28 Aug 2003 18:30:16 -0700 (PDT) Resent-Message-Id: <200308290130.h7T1UGv2018222@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Oliver Eikemeier Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8958616A4BF; Thu, 28 Aug 2003 18:29:27 -0700 (PDT) Received: from mx2.fillmore-labs.com (lima.fillmore-labs.com [62.138.193.83]) by mx1.FreeBSD.org (Postfix) with ESMTP id 56B4C43FCB; Thu, 28 Aug 2003 18:29:26 -0700 (PDT) (envelope-from eikemeier@fillmore-labs.com) Received: from p5080b7aa.dip.t-dialin.net ([80.128.183.170] helo=fillmore-labs.com ident=u1jccaxw9jdxmljj) by mx2.fillmore-labs.com with asmtp (TLSv1:AES256-SHA:256) (Exim 4.22) id 19sY4m-00058G-Vu; Fri, 29 Aug 2003 03:29:21 +0200 Message-Id: <3F4EAC6D.8070802@fillmore-labs.com> Date: Fri, 29 Aug 2003 03:29:17 +0200 From: Oliver Eikemeier To: FreeBSD-gnats-submit@FreeBSD.org cc: "Scot W. Hetze" cc: Joe Marcus Clarke Subject: ports/56111: USE_RC_SUBR doesn't work as documented X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Aug 2003 01:30:18 -0000 >Number: 56111 >Category: ports >Synopsis: USE_RC_SUBR doesn't work as documented >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Thu Aug 28 18:30:16 PDT 2003 >Closed-Date: >Last-Modified: >Originator: Oliver Eikemeier >Release: FreeBSD 4.8-STABLE i386 >Organization: Fillmore Labs - http://www.fillmore-labs.com >Environment: System: FreeBSD nuuk.fillmore-labs.com 4.8-STABLE >Description: USE_RC_SUBR is documented as: # USE_RC_SUBR - Says the ports startup/shutdown script uses the common # routines found in etc/rc.subr and may need to # depend on the sysutils/rc_subr port. # # RC_SUBR - Set to path of rc.subr, defaults to /etc/rc.subr on # 5.x and to ${PREFIX}/etc/rc.subr on non-rcNG # systems. but the definition in ports/Mk/bsd.port.mk is: .if defined(USE_RC_SUBR) RUN_DEPENDS+= ${LOCALBASE}/etc/rc.subr:${PORTSDIR}/sysutils/rc_subr RC_SUBR= ${LOCALBASE}/etc/rc.subr .endif Which means that the port depends on sysutils/rc_subr, even on 5.x systems, and RC_SUBR is ${LOCALBASE}/etc/rc.subr in any case. >How-To-Repeat: >Fix: use the definition from PR ports/54116: .if defined(USE_RC_SUBR) .if exists(/etc/rc.subr) RC_SUBR= /etc/rc.subr .else RUN_DEPENDS+= ${LOCALBASE}/etc/rc.subr:${PORTSDIR}/sysutils/rc_subr RC_SUBR= ${LOCALBASE}/etc/rc.subr .endif .endif or the extended version from port net/openlap22-server: .if defined(USE_RC_SUBR) .if ${OSVERSION} >= 500038 RC_SUBR= /etc/rc.subr RC_DIR= /etc/rc.d RC_SUFX= .else RUN_DEPENDS+= ${LOCALBASE}/etc/rc.subr:${PORTSDIR}/sysutils/rc_subr RC_SUBR= ${LOCALBASE}/etc/rc.subr RC_DIR= ${LOCALBASE}/etc/rc.d RC_SUFX= .sh .endif .endif >Release-Note: >Audit-Trail: >Unformatted: