From owner-cvs-all@FreeBSD.ORG Fri Jun 17 15:27:00 2005 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D06DB16A41C; Fri, 17 Jun 2005 15:27:00 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [204.156.12.53]) by mx1.FreeBSD.org (Postfix) with ESMTP id 825FA43D1F; Fri, 17 Jun 2005 15:27:00 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by cyrus.watson.org (Postfix) with ESMTP id 97CFC46B9E; Fri, 17 Jun 2005 11:26:59 -0400 (EDT) Date: Fri, 17 Jun 2005 16:29:20 +0100 (BST) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Ruslan Ermilov In-Reply-To: <200302262336.h1QNaxEO023353@repoman.freebsd.org> Message-ID: <20050617162704.X56734@fledge.watson.org> References: <200302262336.h1QNaxEO023353@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/config config.y lang.l src/sys/conf makeLINT.mk makeLINT.sed src/sys/alpha/conf Makefile src/sys/i386/conf Makefile NOTES src/sys/pc98/conf Makefile NOTES src/sys/sparc64/conf Makefile NOTES X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Jun 2005 15:27:01 -0000 On Wed, 26 Feb 2003, Ruslan Ermilov wrote: > Implemented "nooption" and "nomakeoption" config(8) tokens. > Fixed memory leak in the "nodevice" option implementation. I've found 'nooption' an incredibly useful entry for kernel configuration files, as it makes maintaining incremental kernel configurations much easier. However, one of the problems I bump into every now and then is that, unlike the 'options' parameter, 'nooptions' performs no validation of its argument. I spent an hour or two this morning trying to track down what appeared to be a 4% performance regression, only to discover that my configuration file included "nooptions INVARIANTS_SUPPORT" instead of "nooptions INVARIANT_SUPPORT". Checking that the argument is a valid option, for some useful definition of valid, would be very helpful... Thanks, Robert N M Watson