From owner-svn-src-all@FreeBSD.ORG Sat Oct 31 17:28:09 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4D3EA106568F; Sat, 31 Oct 2009 17:28:09 +0000 (UTC) (envelope-from mav@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 3AE488FC0A; Sat, 31 Oct 2009 17:28:09 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id n9VHS8p5097275; Sat, 31 Oct 2009 17:28:08 GMT (envelope-from mav@svn.freebsd.org) Received: (from mav@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id n9VHS865097273; Sat, 31 Oct 2009 17:28:08 GMT (envelope-from mav@svn.freebsd.org) Message-Id: <200910311728.n9VHS865097273@svn.freebsd.org> From: Alexander Motin Date: Sat, 31 Oct 2009 17:28:08 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-7@freebsd.org X-SVN-Group: stable-7 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r198720 - in stable/7/sys: . contrib/pf dev/ata X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 31 Oct 2009 17:28:09 -0000 Author: mav Date: Sat Oct 31 17:28:08 2009 New Revision: 198720 URL: http://svn.freebsd.org/changeset/base/198720 Log: MFC rev. 196893: Remove constraint, requiring request data to fulfill controller's alignment requirements. It is busdma task, to manage proper alignment by loading data to bounce buffers. PR: kern/120787, kern/127316 Modified: stable/7/sys/ (props changed) stable/7/sys/contrib/pf/ (props changed) stable/7/sys/dev/ata/ata-dma.c Modified: stable/7/sys/dev/ata/ata-dma.c ============================================================================== --- stable/7/sys/dev/ata/ata-dma.c Sat Oct 31 17:06:36 2009 (r198719) +++ stable/7/sys/dev/ata/ata-dma.c Sat Oct 31 17:28:08 2009 (r198720) @@ -233,9 +233,9 @@ ata_dmaload(device_t dev, caddr_t data, device_printf(dev, "FAILURE - zero length DMA transfer attempted\n"); return EIO; } - if (((uintptr_t)data & (ch->dma->alignment - 1)) || - (count & (ch->dma->alignment - 1))) { - device_printf(dev, "FAILURE - non aligned DMA transfer attempted\n"); + if (count & (ch->dma->alignment - 1)) { + device_printf(dev, "FAILURE - odd-sized DMA transfer attempt %d %% %d\n", + count, ch->dma->alignment); return EIO; } if (count > ch->dma->max_iosize) {