From owner-freebsd-current@FreeBSD.ORG Sat Jun 11 01:45:43 2005 Return-Path: X-Original-To: current@freebsd.org Delivered-To: freebsd-current@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 145C816A41C for ; Sat, 11 Jun 2005 01:45:42 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75]) by mx1.FreeBSD.org (Postfix) with ESMTP id B682443D1F for ; Sat, 11 Jun 2005 01:45:41 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (localhost.localdomain [127.0.0.1]) by odin.ac.hmc.edu (8.13.0/8.13.0) with ESMTP id j5B1jfWw009086; Fri, 10 Jun 2005 18:45:41 -0700 Received: (from brdavis@localhost) by odin.ac.hmc.edu (8.13.0/8.13.0/Submit) id j5B1jf7v009085; Fri, 10 Jun 2005 18:45:41 -0700 Date: Fri, 10 Jun 2005 18:45:41 -0700 From: Brooks Davis To: Brooks Davis Message-ID: <20050611014541.GA8521@odin.ac.hmc.edu> References: <20050610221017.GB17775@odin.ac.hmc.edu> <20050611004705.GD30030@odin.ac.hmc.edu> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="IJpNTDwzlM2Ie8A6" Content-Disposition: inline In-Reply-To: <20050611004705.GD30030@odin.ac.hmc.edu> User-Agent: Mutt/1.4.1i X-Virus-Scanned: by amavisd-new X-Spam-Status: No, hits=0.0 required=8.0 tests=none autolearn=no version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on odin.ac.hmc.edu Cc: current@freebsd.org Subject: Re: WARNING: current unstable X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 Jun 2005 01:45:43 -0000 --IJpNTDwzlM2Ie8A6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jun 10, 2005 at 05:47:05PM -0700, Brooks Davis wrote: > On Fri, Jun 10, 2005 at 03:10:17PM -0700, Brooks Davis wrote: > > It looks like my test systems were running some of the few drivers that > > aren't suffering from a very strange bug. You may wish to avoid > > updating. I'm investigating, but so far, nothing makes much sense. :( >=20 > Good news and bad news. The good news is that I think I've found > the problem (at least I've fixed my vr(4) nic and an fxp nic works). > The bad news is that I broke all the MII based drivers so it's going to > take a while longer to fix (though I hope to do it tonight.) >=20 > The problem is that I didn't notice the device_get_softc() calls > in mii.c that were being cast to ifnet pointers. As a result, all mii > based drivers ended up with mii_ifp values that were actually softcs. > I've committed a hack to get the ifp from the softc by dereferencing the > softc pointer. I now need to audit all miibus users and make sure they > call if_alloc() before mii_phy_probe(). Once I've done that, I need to > work on modifying the mii_phy_probe() API to include the ifp so I can > get rid of the evil casts. OK, most files were well behaved so I only had six to fix. I've commited changes moving if_alloc() up in those files attach functions. I think this should resolve the currently reported panics. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --IJpNTDwzlM2Ie8A6 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFCqkJEXY6L6fI4GtQRAmPqAJsFv3U/kjUwsZqSz5WBjw5uPfzCaQCfShCC lVL3pKoskhQ38QQdiQqd2jc= =Wut7 -----END PGP SIGNATURE----- --IJpNTDwzlM2Ie8A6--