From owner-freebsd-arch@FreeBSD.ORG  Wed Jan 13 00:49:58 2010
Return-Path: <owner-freebsd-arch@FreeBSD.ORG>
Delivered-To: freebsd-arch@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 40B6F106566C;
	Wed, 13 Jan 2010 00:49:58 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85])
	by mx1.freebsd.org (Postfix) with ESMTP id F343A8FC0A;
	Wed, 13 Jan 2010 00:49:57 +0000 (UTC)
Received: from localhost (localhost [127.0.0.1])
	by harmony.bsdimp.com (8.14.3/8.14.1) with ESMTP id o0D0gVUc081359;
	Tue, 12 Jan 2010 17:42:31 -0700 (MST) (envelope-from imp@bsdimp.com)
Date: Tue, 12 Jan 2010 17:43:26 -0700 (MST)
Message-Id: <20100112.174326.337739863389869251.imp@bsdimp.com>
To: dougb@FreeBSD.org
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <4B4D109A.5060500@FreeBSD.org>
References: <alpine.BSF.2.00.1001110348100.92627@serrsnyy.serrofq.bet>
	<20100110.210204.787670930858346133.imp@bsdimp.com>
	<4B4D109A.5060500@FreeBSD.org>
X-Mailer: Mew version 6.3 on Emacs 22.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
	src-committers@FreeBSD.org, freebsd-arch@FreeBSD.org
Subject: Re: INCLUDE_CONFIG_FILE in GENERIC
X-BeenThere: freebsd-arch@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussion related to FreeBSD architecture <freebsd-arch.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arch>
List-Post: <mailto:freebsd-arch@freebsd.org>
List-Help: <mailto:freebsd-arch-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 13 Jan 2010 00:49:58 -0000

In message: <4B4D109A.5060500@FreeBSD.org>
            Doug Barton <dougb@FreeBSD.org> writes:
: On 1/10/2010 8:02 PM, M. Warner Losh wrote:
: > In message: <alpine.BSF.2.00.1001110348100.92627@serrsnyy.serrofq.bet>
: >             Doug Barton <dougb@FreeBSD.org> writes:
: > : On Sun, 10 Jan 2010, Warner Losh wrote:
: > : 
: > : > Author: imp
: > : > Date: Sun Jan 10 17:44:22 2010
: > : > New Revision: 202019
: > : > URL: http://svn.freebsd.org/changeset/base/202019
: > : >
: > : > Log:
: > : >  Add INCLUDE_CONFIG_FILE in GENERIC on all non-embedded platforms.
: > : 
: > : Thanks for doing this, however the comment about how to include the
: > : whole file (including the comments) were not included. Do I need to do
: > : this part of it myself? No problem if so, I just want to be sure to
: > : get it done in time to MFC it before the freeze for 7.3-release.
: > 
: > In general, we don't put big comments like that in the config files,
: > preferring to leave them to NOTES.  I was just following that
: > convention...
: 
: Understood, however given that there is plenty of room for confusion on
: this point because the default is NOT to include the comments I think
: that some explanation is justified. My original text was:
: 
: # Store the plain version of the configuration file in the kernel itself.
: # To store the entire file, including comments, put this in /etc/src.conf:
: # CONFIGARGS=	-C
: # See config(8) for more details.
: 
: I'm open to suggestions on shrinking it, but I do think some sort of
: explanation is warranted.

I'm not sure I see where there's confusion possible here, let alone
plenty of room for it.  Do you think you can describe what confusion
is possible here?

Warner